Re: [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-17 Thread Mike Frysinger
On Thursday 14 February 2013 14:35:58 Benson Leung wrote: > + asm volatile ("mov %%ebx, %%edi;" /* save ebx (for PIC) */ > + "cpuid;" > + "mov %%ebx, %%esi;" /* pass to caller */ > + "mov %%edi, %%ebx;" /* restore ebx */ > +

Re: [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-17 Thread Len Brown
Hi Benson, checkpatch.pl doesn't love this syntax: ERROR: spaces required around that ':' (ctx:ExV) #113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142: + :"+a" (_eax), "=S" (_ebx), "=c" (_ecx), "=d" (_edx) ^ ERROR: spaces req