Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-02 Thread Ingo Molnar
* h...@zytor.com wrote: > On February 1, 2017 11:16:00 PM PST, Ingo Molnar wrote: > > > >* Nicolas Iooss wrote: > > > >> With %Ld, my compiler (gcc 6.3.1 on x86_64) complains: > >> > >> arch/x86/tools/relocs.c:400:7: error: format ‘%Ld’ expects argument > >of > >> type ‘long long int’, but ar

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-02 Thread Nicolas Iooss
On 02/02/17 02:39, h...@zytor.com wrote: > On January 31, 2017 10:52:11 AM PST, Nicolas Iooss > wrote: >> Hello, >> >> As I have not received any comment on the patch I sent in December, I >> am >> wondering whether I did anything wrong with it. How can I get it queued >> for the next merge windo

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-01 Thread hpa
On February 1, 2017 11:16:00 PM PST, Ingo Molnar wrote: > >* Nicolas Iooss wrote: > >> With %Ld, my compiler (gcc 6.3.1 on x86_64) complains: >> >> arch/x86/tools/relocs.c:400:7: error: format ‘%Ld’ expects argument >of >> type ‘long long int’, but argument 2 has type ‘Elf64_Off {aka long >> uns

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-01 Thread Ingo Molnar
* Nicolas Iooss wrote: > With %Ld, my compiler (gcc 6.3.1 on x86_64) complains: > > arch/x86/tools/relocs.c:400:7: error: format ‘%Ld’ expects argument of > type ‘long long int’, but argument 2 has type ‘Elf64_Off {aka long > unsigned int}’ [-Werror=format=] How did it pick up that type as an

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-01 Thread hpa
On January 31, 2017 10:52:11 AM PST, Nicolas Iooss wrote: >Hello, > >As I have not received any comment on the patch I sent in December, I >am >wondering whether I did anything wrong with it. How can I get it queued >for the next merge window? > >Thanks, >Nicolas > >On 18/12/16 20:47, Nicolas Ioo

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-01 Thread Nicolas Iooss
On 01/02/17 10:04, Ingo Molnar wrote: > > * Nicolas Iooss wrote: > >> Adding such an attribute helps to detect errors in the format string at >> build time. After doing this, the compiler complains about such issues: >> >> arch/x86/tools/relocs.c:460:5: error: format specifies type 'int' >>

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-02-01 Thread Ingo Molnar
* Nicolas Iooss wrote: > Adding such an attribute helps to detect errors in the format string at > build time. After doing this, the compiler complains about such issues: > > arch/x86/tools/relocs.c:460:5: error: format specifies type 'int' > but the argument has type 'Elf64_Xword' (aka

Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

2017-01-31 Thread Nicolas Iooss
Hello, As I have not received any comment on the patch I sent in December, I am wondering whether I did anything wrong with it. How can I get it queued for the next merge window? Thanks, Nicolas On 18/12/16 20:47, Nicolas Iooss wrote: > Adding such an attribute helps to detect errors in the form