Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-09 Thread Brendan Higgins
On Thu, Apr 8, 2021 at 10:19 AM Daniel Latypov wrote: > > On Thu, Apr 8, 2021 at 3:30 AM Marco Elver wrote: > > > > On Tue, 6 Apr 2021 at 12:57, Vlastimil Babka wrote: > > > > > > > > > On 4/1/21 11:24 PM, Marco Elver wrote: > > > > On Thu, 1 Apr 2021 at 21:04, Daniel Latypov wrote: > > > >> >

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-08 Thread Daniel Latypov
On Thu, Apr 8, 2021 at 3:30 AM Marco Elver wrote: > > On Tue, 6 Apr 2021 at 12:57, Vlastimil Babka wrote: > > > > > > On 4/1/21 11:24 PM, Marco Elver wrote: > > > On Thu, 1 Apr 2021 at 21:04, Daniel Latypov wrote: > > >> > } > > >> > #else > > >> > static inline bool

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-08 Thread Marco Elver
On Tue, 6 Apr 2021 at 12:57, Vlastimil Babka wrote: > > > On 4/1/21 11:24 PM, Marco Elver wrote: > > On Thu, 1 Apr 2021 at 21:04, Daniel Latypov wrote: > >> > } > >> > #else > >> > static inline bool slab_add_kunit_errors(void) { return false; } > >> > #endif > >>

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-06 Thread Vlastimil Babka
On 4/1/21 11:24 PM, Marco Elver wrote: > On Thu, 1 Apr 2021 at 21:04, Daniel Latypov wrote: >> > } >> > #else >> > static inline bool slab_add_kunit_errors(void) { return false; } >> > #endif >> > >> > And anywhere you want to increase the error count, you'd call

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-02 Thread Brendan Higgins
On Thu, Apr 1, 2021 at 12:04 PM 'Daniel Latypov' via KUnit Development wrote: > > On Thu, Apr 1, 2021 at 2:16 AM 'Marco Elver' via KUnit Development > wrote: [...] > > #else > > static inline bool slab_add_kunit_errors(void) { return false; } > > #endif > > > > And

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-01 Thread Marco Elver
On Thu, 1 Apr 2021 at 21:04, Daniel Latypov wrote: ... > > > --- a/include/linux/slub_def.h > > > +++ b/include/linux/slub_def.h > > > @@ -133,6 +133,8 @@ struct kmem_cache { > > > unsigned int usersize; /* Usercopy region size */ > > > > > > struct kmem_cache_node

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-01 Thread Daniel Latypov
On Thu, Apr 1, 2021 at 2:16 AM 'Marco Elver' via KUnit Development wrote: > > [Note, if you'd like me to see future versions, please Cc me, otherwise > it's unlikely I see it in time. Also add kunit-...@googlegroups.com if > perhaps a KUnit dev should have another look, too.] > > On Wed, Mar 31,

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-01 Thread Marco Elver
[Note, if you'd like me to see future versions, please Cc me, otherwise it's unlikely I see it in time. Also add kunit-...@googlegroups.com if perhaps a KUnit dev should have another look, too.] On Wed, Mar 31, 2021 at 10:51AM +0200, glit...@gmail.com wrote: > From: Oliver Glitta > > SLUB has

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-01 Thread Vlastimil Babka
On 3/31/21 10:51 AM, glit...@gmail.com wrote: > From: Oliver Glitta > > SLUB has resiliency_test() function which is hidden behind #ifdef > SLUB_RESILIENCY_TEST that is not part of Kconfig, so nobody > runs it. KUnit should be a proper replacement for it. > > Try changing byte in redzone after