Re: [PATCH v3 1/3] KVM: arm/arm64: vgic: Make vgic_irq->irq_lock a raw_spinlock

2019-02-01 Thread Julien Grall
Hi Julia, On 01/02/2019 17:36, Julia Cartwright wrote: On Fri, Feb 01, 2019 at 03:30:58PM +, Julien Grall wrote: Hi Julien, On 07/01/2019 15:06, Julien Thierry wrote: vgic_irq->irq_lock must always be taken with interrupts disabled as it is used in interrupt context. I am a bit confused

Re: Re: [PATCH v3 1/3] KVM: arm/arm64: vgic: Make vgic_irq->irq_lock a raw_spinlock

2019-02-01 Thread Julia Cartwright
On Fri, Feb 01, 2019 at 03:30:58PM +, Julien Grall wrote: > Hi Julien, > > On 07/01/2019 15:06, Julien Thierry wrote: > > vgic_irq->irq_lock must always be taken with interrupts disabled as > > it is used in interrupt context. > > I am a bit confused with the reason here. The code mention tha

Re: [PATCH v3 1/3] KVM: arm/arm64: vgic: Make vgic_irq->irq_lock a raw_spinlock

2019-02-01 Thread Julien Grall
Hi Julien, On 07/01/2019 15:06, Julien Thierry wrote: vgic_irq->irq_lock must always be taken with interrupts disabled as it is used in interrupt context. I am a bit confused with the reason here. The code mention that ap_list_lock could be taken from the timer interrupt handler interrupt. I