Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Johan Hovold
On Mon, Sep 08, 2014 at 04:20:34PM +0300, Octavian Purdila wrote: > On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote: > > > +static bool find_free_slot(struct dln2_mod_rx_slots *rxs, int *slot) > > > +{ > > > + unsigned long flags; > > > + > > > + spin_lock_irqsave(&rxs->lock, flags); >

Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Lee Jones
On Mon, 08 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote: > > > > On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote: > > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > > Master Adapter DLN-2. Details about the device

Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Octavian Purdila
On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote: > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > Master Adapter DLN-2. Details about the device can be found here: > > > > First of all, this is much

Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Johan Hovold
On Mon, Sep 08, 2014 at 01:32:33PM +0200, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote: > > +static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, > > + void *obuf, int obuf_len, void *ibuf, int *ibuf_len) > > +{ > >

Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote: > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information about the USB protocol can b