Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Jean-Francois Moine
On Sat, 3 Aug 2013 13:46:52 +0100 Russell King - ARM Linux wrote: > On Wed, Jul 31, 2013 at 08:17:39AM +0200, Jean-Francois Moine wrote: > > The function kirkwood_i2s_dev_remove() may be used when probe fails. > > Looking at this deeper, I'm not happy with this. [snip] > What this means

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Mark Brown
On Sat, Aug 03, 2013 at 05:10:29PM +0100, Russell King - ARM Linux wrote: > having to run around and pull random trees. In other words, you should > have Cc'd interested parties on that devm_* change patch - especially > myself as I was the one who introduced that code. That was me, sorry - Jean

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Russell King - ARM Linux
On Sat, Aug 03, 2013 at 05:55:13PM +0200, Jean-Francois Moine wrote: > On Sat, 3 Aug 2013 13:39:54 +0100 > Russell King - ARM Linux wrote: > > > This doesn't apply to mainline as there's a clk_put() there. > > Right, it applies to linux-next: > > On Fri, 26 Jul 2013 11:32:50 +0100, Mark Brown

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Jean-Francois Moine
On Sat, 3 Aug 2013 13:39:54 +0100 Russell King - ARM Linux wrote: > This doesn't apply to mainline as there's a clk_put() there. Right, it applies to linux-next: On Fri, 26 Jul 2013 11:32:50 +0100, Mark Brown wrote: > Always submit against where the code will be applied - -next in this > case

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Russell King - ARM Linux
On Wed, Jul 31, 2013 at 08:17:39AM +0200, Jean-Francois Moine wrote: > The function kirkwood_i2s_dev_remove() may be used when probe fails. Looking at this deeper, I'm not happy with this. > +static int kirkwood_i2s_dev_remove(struct platform_device *pdev) > +{ > + struct kirkwood_dma_data *p

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Russell King - ARM Linux
On Wed, Jul 31, 2013 at 08:17:39AM +0200, Jean-Francois Moine wrote: > @@ -519,30 +532,17 @@ static int kirkwood_i2s_dev_probe(struct > platform_device *pdev) > > err = snd_soc_register_component(&pdev->dev, &kirkwood_i2s_component, >soc_dai, 1); > -