Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread Martin Blumenstingl
Hi Thierry, On Mon, Sep 5, 2016 at 11:53 AM, Thierry Reding wrote: > As mentioned in another reply in this thread I ended up restructuring > the driver a little before applying it to the PWM tree. I don't /think/ > there are any functional changes, so I left your Tested-by in place, but > it woul

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread jbrunet
On Tue, 2016-09-06 at 12:04 +0200, Thierry Reding wrote: > On Tue, Sep 06, 2016 at 11:14:45AM +0200, Neil Armstrong wrote: > > > > On 09/06/2016 11:07 AM, Thierry Reding wrote: > > > > > > On Tue, Sep 06, 2016 at 10:36:49AM +0200, Neil Armstrong wrote: > > > > > > > > Hi Thierry, > > > > > > [.

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread Thierry Reding
On Tue, Sep 06, 2016 at 11:14:45AM +0200, Neil Armstrong wrote: > On 09/06/2016 11:07 AM, Thierry Reding wrote: > > On Tue, Sep 06, 2016 at 10:36:49AM +0200, Neil Armstrong wrote: > >> Hi Thierry, > >> > [...] > > > >> > >> The second bug is in probe(), I understand the point to allocate > >> dyna

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread Neil Armstrong
On 09/06/2016 11:07 AM, Thierry Reding wrote: > On Tue, Sep 06, 2016 at 10:36:49AM +0200, Neil Armstrong wrote: >> Hi Thierry, >> [...] > >> >> The second bug is in probe(), I understand the point to allocate >> dynamically the channels and attach them to each pwm chip, but when >> calling meson_p

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread Thierry Reding
On Tue, Sep 06, 2016 at 10:36:49AM +0200, Neil Armstrong wrote: > Hi Thierry, > > On 09/05/2016 11:00 AM, Thierry Reding wrote: > > On Mon, Aug 22, 2016 at 05:36:30PM +0200, Neil Armstrong wrote: > >> Add support for the PWM controller found in the Amlogic SoCs. > >> This driver supports the Meson

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread Neil Armstrong
Hi Thierry, On 09/05/2016 11:00 AM, Thierry Reding wrote: > On Mon, Aug 22, 2016 at 05:36:30PM +0200, Neil Armstrong wrote: >> Add support for the PWM controller found in the Amlogic SoCs. >> This driver supports the Meson8b and GXBB SoCs. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/pw

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-05 Thread Thierry Reding
On Sun, Aug 28, 2016 at 06:33:03PM +0200, Martin Blumenstingl wrote: > On Mon, Aug 22, 2016 at 5:36 PM, Neil Armstrong > wrote: > > Add support for the PWM controller found in the Amlogic SoCs. > > This driver supports the Meson8b and GXBB SoCs. > > > > Signed-off-by: Neil Armstrong > I could en

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-05 Thread Neil Armstrong
On 09/05/2016 11:00 AM, Thierry Reding wrote: > On Mon, Aug 22, 2016 at 05:36:30PM +0200, Neil Armstrong wrote: >> Add support for the PWM controller found in the Amlogic SoCs. >> This driver supports the Meson8b and GXBB SoCs. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/pwm/Kconfig

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-05 Thread Thierry Reding
On Mon, Aug 22, 2016 at 05:36:30PM +0200, Neil Armstrong wrote: > Add support for the PWM controller found in the Amlogic SoCs. > This driver supports the Meson8b and GXBB SoCs. > > Signed-off-by: Neil Armstrong > --- > drivers/pwm/Kconfig | 9 + > drivers/pwm/Makefile| 1 + > driver

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-08-28 Thread Martin Blumenstingl
On Mon, Aug 22, 2016 at 5:36 PM, Neil Armstrong wrote: > Add support for the PWM controller found in the Amlogic SoCs. > This driver supports the Meson8b and GXBB SoCs. > > Signed-off-by: Neil Armstrong I could enable the AP6330 SDIO wifi module with this on my meson-gxbb-vega-s95-meta clone, whi