Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Thomas Gleixner
On Fri, Oct 09 2020 at 11:52, Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 04:44:27PM +0200, Thomas Gleixner wrote: >> > This is really not that different from what I was describing for queue >> > contexts - the queue context needs to be assigned to the irq # before >> > it can be used in the i

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 04:44:27PM +0200, Thomas Gleixner wrote: > > This is really not that different from what I was describing for queue > > contexts - the queue context needs to be assigned to the irq # before > > it can be used in the irq chip other wise there is no idea where to > > write the

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Thomas Gleixner
On Thu, Oct 08 2020 at 20:32, Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 01:17:38AM +0200, Thomas Gleixner wrote: >> Thinking more about it, that very same thing will be needed for any >> other IMS device and of course this is not going to end well because >> some driver will fiddle with the

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Raj, Ashok
On Fri, Oct 09, 2020 at 10:12:18AM -0300, Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 06:02:09AM -0700, Raj, Ashok wrote: > > On Fri, Oct 09, 2020 at 09:49:45AM -0300, Jason Gunthorpe wrote: > > > On Fri, Oct 09, 2020 at 05:43:07AM -0700, Raj, Ashok wrote: > > > > On Fri, Oct 09, 2020 at 08:57

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 06:02:09AM -0700, Raj, Ashok wrote: > On Fri, Oct 09, 2020 at 09:49:45AM -0300, Jason Gunthorpe wrote: > > On Fri, Oct 09, 2020 at 05:43:07AM -0700, Raj, Ashok wrote: > > > On Fri, Oct 09, 2020 at 08:57:37AM -0300, Jason Gunthorpe wrote: > > > > On Thu, Oct 08, 2020 at 06:22

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Raj, Ashok
On Fri, Oct 09, 2020 at 09:49:45AM -0300, Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 05:43:07AM -0700, Raj, Ashok wrote: > > On Fri, Oct 09, 2020 at 08:57:37AM -0300, Jason Gunthorpe wrote: > > > On Thu, Oct 08, 2020 at 06:22:31PM -0700, Raj, Ashok wrote: > > > > > > > Not randomly put there

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 05:43:07AM -0700, Raj, Ashok wrote: > On Fri, Oct 09, 2020 at 08:57:37AM -0300, Jason Gunthorpe wrote: > > On Thu, Oct 08, 2020 at 06:22:31PM -0700, Raj, Ashok wrote: > > > > > Not randomly put there Jason :-).. There is a good reason for it. > > > > Sure the PASID value

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Raj, Ashok
On Fri, Oct 09, 2020 at 08:57:37AM -0300, Jason Gunthorpe wrote: > On Thu, Oct 08, 2020 at 06:22:31PM -0700, Raj, Ashok wrote: > > > Not randomly put there Jason :-).. There is a good reason for it. > > Sure the PASID value being associated with the IRQ make sense, but > combining that register

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-09 Thread Jason Gunthorpe
On Thu, Oct 08, 2020 at 06:22:31PM -0700, Raj, Ashok wrote: > Not randomly put there Jason :-).. There is a good reason for it. Sure the PASID value being associated with the IRQ make sense, but combining that register with the interrupt mask is just a compltely random thing to do. If this HW w

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Raj, Ashok
Hi Jason On Thu, Oct 08, 2020 at 08:32:10PM -0300, Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 01:17:38AM +0200, Thomas Gleixner wrote: > > Dave, > > > > On Thu, Oct 08 2020 at 09:51, Dave Jiang wrote: > > > On 10/8/2020 12:39 AM, Thomas Gleixner wrote: > > >> On Wed, Oct 07 2020 at 14:54, D

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Dave Jiang
On 10/8/2020 4:32 PM, Jason Gunthorpe wrote: On Fri, Oct 09, 2020 at 01:17:38AM +0200, Thomas Gleixner wrote: Dave, On Thu, Oct 08 2020 at 09:51, Dave Jiang wrote: On 10/8/2020 12:39 AM, Thomas Gleixner wrote: On Wed, Oct 07 2020 at 14:54, Dave Jiang wrote: On 9/30/2020 12:57 PM, Thomas G

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 01:17:38AM +0200, Thomas Gleixner wrote: > Dave, > > On Thu, Oct 08 2020 at 09:51, Dave Jiang wrote: > > On 10/8/2020 12:39 AM, Thomas Gleixner wrote: > >> On Wed, Oct 07 2020 at 14:54, Dave Jiang wrote: > >>> On 9/30/2020 12:57 PM, Thomas Gleixner wrote: > Aside of th

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Thomas Gleixner
Dave, On Thu, Oct 08 2020 at 09:51, Dave Jiang wrote: > On 10/8/2020 12:39 AM, Thomas Gleixner wrote: >> On Wed, Oct 07 2020 at 14:54, Dave Jiang wrote: >>> On 9/30/2020 12:57 PM, Thomas Gleixner wrote: Aside of that this is fiddling in the IMS storage array behind the irq chips back wit

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Dave Jiang
On 10/8/2020 12:39 AM, Thomas Gleixner wrote: On Wed, Oct 07 2020 at 14:54, Dave Jiang wrote: On 9/30/2020 12:57 PM, Thomas Gleixner wrote: Aside of that this is fiddling in the IMS storage array behind the irq chips back without any comment here and a big fat comment about the shared usage

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-08 Thread Thomas Gleixner
On Wed, Oct 07 2020 at 14:54, Dave Jiang wrote: > On 9/30/2020 12:57 PM, Thomas Gleixner wrote: >> Aside of that this is fiddling in the IMS storage array behind the irq >> chips back without any comment here and a big fat comment about the >> shared usage of ims_slot::ctrl in the irq chip driver.

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-10-07 Thread Dave Jiang
On 9/30/2020 12:57 PM, Thomas Gleixner wrote: > On Tue, Sep 15 2020 at 16:28, Dave Jiang wrote: >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig >> index a39392157dc2..115a8f49aab3 100644 >> --- a/drivers/dma/Kconfig >> +++ b/drivers/dma/Kconfig >> @@ -301,6 +301,7 @@ config INTEL_IDXD_

Re: [PATCH v3 11/18] dmaengine: idxd: ims setup for the vdcm

2020-09-30 Thread Thomas Gleixner
On Tue, Sep 15 2020 at 16:28, Dave Jiang wrote: > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index a39392157dc2..115a8f49aab3 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -301,6 +301,7 @@ config INTEL_IDXD_MDEV > depends on INTEL_IDXD > depends on VF