Re: [PATCH v3 13/15] KVM: MMU: locklessly write-protect the page

2013-10-24 Thread Xiao Guangrong
On 10/24/2013 05:17 PM, Gleb Natapov wrote: >> >> -/** >> - * kvm_mmu_write_protect_pt_masked - write protect selected PT level pages >> +static void __rmap_write_protect_lockless(u64 *sptep) >> +{ >> +u64 spte; >> + >> +retry: >> +/* >> + * Note we may partly read the sptep on 32bit

Re: [PATCH v3 13/15] KVM: MMU: locklessly write-protect the page

2013-10-24 Thread Gleb Natapov
On Thu, Oct 24, 2013 at 05:24:12PM +0800, Xiao Guangrong wrote: > On 10/24/2013 05:17 PM, Gleb Natapov wrote: > > >> > >> -/** > >> - * kvm_mmu_write_protect_pt_masked - write protect selected PT level pages > >> +static void __rmap_write_protect_lockless(u64 *sptep) > >> +{ > >> + u64 spte; >

Re: [PATCH v3 13/15] KVM: MMU: locklessly write-protect the page

2013-10-24 Thread Gleb Natapov
On Wed, Oct 23, 2013 at 09:29:31PM +0800, Xiao Guangrong wrote: > Currently, when mark memslot dirty logged or get dirty page, we need to > write-protect large guest memory, it is the heavy work, especially, we > need to hold mmu-lock which is also required by vcpu to fix its page table > fault and