Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-05-13 Thread Andreas Dannenberg
Mark, please see below... On Fri, May 13, 2016 at 12:55:40PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 01:01:05PM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 06:29:36PM +0100, Mark Brown wrote: > > > > Is the device actually going to mess up if someone sends it something

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-05-13 Thread Mark Brown
On Tue, Apr 26, 2016 at 01:01:05PM -0500, Andreas Dannenberg wrote: > On Tue, Apr 26, 2016 at 06:29:36PM +0100, Mark Brown wrote: > > Is the device actually going to mess up if someone sends it something > > else or is it just going to ignore the extra bits (given that it's doing > > autodetection

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 06:29:36PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 11:22:40AM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 04:43:13PM +0100, Mark Brown wrote: > > > > If the driver doesn't do anything just remove the code. > > > Well it's doing something which i

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 12:19:05PM -0500, Andrew F. Davis wrote: > On 04/25/2016 03:17 PM, Andreas Dannenberg wrote: > > The Texas Instruments TAS5720L/M device is a high-efficiency mono > > Class-D audio power amplifier optimized for high transient power > > capability to use the dynamic power hea

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Mark Brown
On Tue, Apr 26, 2016 at 11:22:40AM -0500, Andreas Dannenberg wrote: > On Tue, Apr 26, 2016 at 04:43:13PM +0100, Mark Brown wrote: > > If the driver doesn't do anything just remove the code. > Well it's doing something which is making sure the nobody passes in a > sample size that's not supported.

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andrew F. Davis
On 04/25/2016 03:17 PM, Andreas Dannenberg wrote: > The Texas Instruments TAS5720L/M device is a high-efficiency mono > Class-D audio power amplifier optimized for high transient power > capability to use the dynamic power headroom of small loudspeakers. > Its digital time division multiplexed (TDM

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
Hi Mark, thanks for the continued feedback, please see below... On Tue, Apr 26, 2016 at 04:43:13PM +0100, Mark Brown wrote: > On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote: > > This looks mostly good, a few small things below. > > > + switch (width) { > > + case 16: > >

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Mark Brown
On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote: This looks mostly good, a few small things below. > + switch (width) { > + case 16: > + case 18: > + case 20: > + case 24: > + /* > + * We only support the different left-justified ser