Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-09 Thread Lee Jones
On Mon, 08 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 8, 2014 at 7:30 PM, Johan Hovold wrote: > > On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote: > >> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote: > >> > >> > >> > >> Hi Johan, > >> > >> Again, thanks for the detaile

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-08 Thread Johan Hovold
On Mon, Sep 08, 2014 at 08:15:07PM +0300, Octavian Purdila wrote: > Just one more question on this subject: is the following allowed: > > int ret, len; > > or should it be: > > int ret; > int len; I try to avoid it, at least unless obviously related such as min/max or x/y. Johan -- To unsubsc

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-08 Thread Octavian Purdila
On Mon, Sep 8, 2014 at 7:30 PM, Johan Hovold wrote: > On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote: >> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote: >> >> >> >> Hi Johan, >> >> Again, thanks for the detailed review, I am addressing your review >> comments as we speak. S

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-08 Thread Johan Hovold
On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote: > On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote: > > > > Hi Johan, > > Again, thanks for the detailed review, I am addressing your review > comments as we speak. Some questions below. > > > > > > + int ret, len; > >

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-08 Thread Octavian Purdila
On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote: Hi Johan, Again, thanks for the detailed review, I am addressing your review comments as we speak. Some questions below. > > + int ret, len; > > + struct tx_data { > > + u8 port; > > + u8 addr; > > +

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-08 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:58PM +0300, Octavian Purdila wrote: > From: Laurentiu Palcu > > This patch adds support for the Diolan DLN-2 I2C master module. Due > to hardware limitations it does not support SMBUS quick commands. > > Information about the USB protocol interface can be found in t