Re: [PATCH v3 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-08 Thread Alexandre Torgue
Hi Thomas, On 09/02/2016 08:57 PM, Thomas Gleixner wrote: > Alexandre, > > On Fri, 2 Sep 2016, Alexandre TORGUE wrote: > > This all looks very reasonable. The only complaint I have is your variable > declaration ordering or the lack thereof. > > 1) >> +struct irq_domain *domain = irq_desc_get_

Re: [PATCH v3 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-05 Thread Alexandre Torgue
Hi Thomas, On 09/02/2016 08:57 PM, Thomas Gleixner wrote: Alexandre, On Fri, 2 Sep 2016, Alexandre TORGUE wrote: This all looks very reasonable. The only complaint I have is your variable declaration ordering or the lack thereof. 1) + struct irq_domain *domain = irq_desc_get_handler_da

Re: [PATCH v3 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-02 Thread Thomas Gleixner
Alexandre, On Fri, 2 Sep 2016, Alexandre TORGUE wrote: This all looks very reasonable. The only complaint I have is your variable declaration ordering or the lack thereof. 1) > + struct irq_domain *domain = irq_desc_get_handler_data(desc); > + struct irq_chip_generic *gc = domain->gc->gc