Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-18 Thread Viresh Kumar
On 02-11-20, 12:01, Nicola Mazzucato wrote: > Second proposal: > > Another option could be for each driver to store internally the performance > dependencies and let the driver directly provide the correct cpumask for > any consumer. >From the discussion that happened in this thread, looks like w

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-18 Thread Viresh Kumar
On 18-11-20, 13:00, Rafael J. Wysocki wrote: > On Wed, Nov 18, 2020 at 5:42 AM Viresh Kumar wrote: > > > > On 17-11-20, 14:06, Rafael J. Wysocki wrote: > > > Is this really a cpufreq thing, though, or is it arch stuff? I think > > > the latter, because it is not necessary for anything in cpufreq.

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-18 Thread Rafael J. Wysocki
On Wed, Nov 18, 2020 at 5:42 AM Viresh Kumar wrote: > > On 17-11-20, 14:06, Rafael J. Wysocki wrote: > > Is this really a cpufreq thing, though, or is it arch stuff? I think > > the latter, because it is not necessary for anything in cpufreq. > > > > Yes, acpi-cpufreq happens to know this informa

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Viresh Kumar
On 17-11-20, 14:06, Rafael J. Wysocki wrote: > Is this really a cpufreq thing, though, or is it arch stuff? I think > the latter, because it is not necessary for anything in cpufreq. > > Yes, acpi-cpufreq happens to know this information, because it uses > processor_perflib, but the latter may as

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Rafael J. Wysocki
On Tue, Nov 17, 2020 at 11:53 AM Viresh Kumar wrote: > > On 17-11-20, 10:47, Nicola Mazzucato wrote: > > Freq-invariance has been mentioned. I suppose the fix will depend on which > > strategy we prefer to solve this. > > I am not sure how FIE will use this information, as I thought the > problem

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Viresh Kumar
On 17-11-20, 10:47, Lukasz Luba wrote: > Fair enough. What if we come back with experiments results in future? > Currently we are trying to conduct experiments with Nicola on modified Juno > firmware and kernel) Sure. If we think it improves things, why not. I just wanted to make sure we understan

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Viresh Kumar
On 17-11-20, 10:47, Nicola Mazzucato wrote: > Freq-invariance has been mentioned. I suppose the fix will depend on which > strategy we prefer to solve this. I am not sure how FIE will use this information, as I thought the problem is about knowing the current frequency on a CPU instead of which CP

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Lukasz Luba
On 11/17/20 10:11 AM, Viresh Kumar wrote: On 16-11-20, 11:33, Lukasz Luba wrote: On 11/9/20 6:57 AM, Viresh Kumar wrote: On 06-11-20, 11:14, Lukasz Luba wrote: I also had similar doubts, because if we make frequency requests independently for each CPU, why not having N cooling devs, which w

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Nicola Mazzucato
Hi Viresh, On 11/17/20 10:11 AM, Viresh Kumar wrote: > On 16-11-20, 11:33, Lukasz Luba wrote: >> On 11/9/20 6:57 AM, Viresh Kumar wrote: >>> On 06-11-20, 11:14, Lukasz Luba wrote: I also had similar doubts, because if we make frequency requests independently for each CPU, why not having

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-17 Thread Viresh Kumar
On 16-11-20, 11:33, Lukasz Luba wrote: > On 11/9/20 6:57 AM, Viresh Kumar wrote: > > On 06-11-20, 11:14, Lukasz Luba wrote: > > > I also had similar doubts, because if we make frequency requests > > > independently for each CPU, why not having N cooling devs, which > > > will set independently QoS

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-16 Thread Lukasz Luba
On 11/9/20 6:57 AM, Viresh Kumar wrote: On 06-11-20, 11:14, Lukasz Luba wrote: I also had similar doubts, because if we make frequency requests independently for each CPU, why not having N cooling devs, which will set independently QoS max freq for them... What convinced me: EAS and FIE woul

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-08 Thread Viresh Kumar
On 06-11-20, 11:14, Lukasz Luba wrote: > I also had similar doubts, because if we make frequency requests > independently for each CPU, why not having N cooling devs, which > will set independently QoS max freq for them... > > What convinced me: > EAS and FIE would know the 'real' frequency of the

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-06 Thread Lukasz Luba
On 11/6/20 10:55 AM, Viresh Kumar wrote: On 06-11-20, 10:37, Lukasz Luba wrote: Good question. How about a different interface for those cpufreq drivers? That new registration API would allow to specify the cpumask. Or rely on EM cpumask: em_span_cpus(em) Currently we have two ways to regis

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-06 Thread Viresh Kumar
On 06-11-20, 10:37, Lukasz Luba wrote: > Good question. > > How about a different interface for those cpufreq drivers? > That new registration API would allow to specify the cpumask. > Or rely on EM cpumask: em_span_cpus(em) > > Currently we have two ways to register cooling device: > 1. when the

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-06 Thread Lukasz Luba
Hi Viresh, On 11/6/20 9:20 AM, Viresh Kumar wrote: On 02-11-20, 12:01, Nicola Mazzucato wrote: This is a continuation of the previous v2, where we focused mostly on the dt binding. I am seeking some feedback/comments on the following two approaches. Intro: We have seen that in a system where

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-06 Thread Viresh Kumar
On 02-11-20, 12:01, Nicola Mazzucato wrote: > Hi All, > > This is a continuation of the previous v2, where we focused mostly on the > dt binding. > > I am seeking some feedback/comments on the following two approaches. > > Intro: > We have seen that in a system where performance control and hard

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-06 Thread Viresh Kumar
On 02-11-20, 12:01, Nicola Mazzucato wrote: > This is a continuation of the previous v2, where we focused mostly on the > dt binding. > > I am seeking some feedback/comments on the following two approaches. > > Intro: > We have seen that in a system where performance control and hardware > descri