Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-27 Thread Russell King - ARM Linux
On Mon, Jul 27, 2015 at 11:01:03AM +0100, Lorenzo Pieralisi wrote: > Mark's series consolidate ARM/ARM64 PSCI implementations, it does not > require creating anything in arch/arm actually it moves code in arch/arm > to drivers/firmware, consolidating it, it is definitely the right > thing to do in

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-27 Thread Lorenzo Pieralisi
On Mon, Jul 27, 2015 at 10:45:07AM +0100, Russell King - ARM Linux wrote: > On Mon, Jul 27, 2015 at 10:16:02AM +0100, Lorenzo Pieralisi wrote: > > Yes, I would only ask you, if the plan above (which can be implemented > > in two steps) makes sense to you please consider accepting Mark's change > >

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-27 Thread Russell King - ARM Linux
On Mon, Jul 27, 2015 at 10:16:02AM +0100, Lorenzo Pieralisi wrote: > Yes, I would only ask you, if the plan above (which can be implemented > in two steps) makes sense to you please consider accepting Mark's change > to consolidate PSCI code into drivers/firmware/psci, it is a stepping stone > with

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-27 Thread Lorenzo Pieralisi
On Sun, Jul 26, 2015 at 10:45:54PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 15, 2015 at 04:40:56PM +0100, Lorenzo Pieralisi wrote: > > static struct cpuidle_ops psci_cpuidle_ops __initdata = { > > .suspend = cpu_psci_cpu_suspend, > > .init = cpu_psci_cpu_init_idle, > > }; > > CP

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-26 Thread Russell King - ARM Linux
On Wed, Jul 15, 2015 at 04:40:56PM +0100, Lorenzo Pieralisi wrote: > static struct cpuidle_ops psci_cpuidle_ops __initdata = { > .suspend = cpu_psci_cpu_suspend, > .init = cpu_psci_cpu_init_idle, > }; > CPUIDLE_METHOD_OF_DECLARE(psci_cpuidle, "psci", &psci_cpuidle_ops); > > to drivers/

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-15 Thread Lorenzo Pieralisi
On Wed, Jul 15, 2015 at 03:45:07PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 15, 2015 at 02:46:03PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Jul 14, 2015 at 09:41:38PM +0100, Russell King - ARM Linux wrote: > > > Sorry, NAK, and end of discussion. There is nothing more to be said > >

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-15 Thread Russell King - ARM Linux
On Wed, Jul 15, 2015 at 02:46:03PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jul 14, 2015 at 09:41:38PM +0100, Russell King - ARM Linux wrote: > > Sorry, NAK, and end of discussion. There is nothing more to be said > > here. > > I beg to differ. To solve the issue that you brought up with this se

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-15 Thread Lorenzo Pieralisi
On Tue, Jul 14, 2015 at 09:41:38PM +0100, Russell King - ARM Linux wrote: [...] > > > Yet, we're stuffing _all_ the PSCI CPU idle code into > > > drivers/firmware/psci.c, but then stuffing the PSCI OF data structures > > > into arch/arm. This is utterly _insane_. > > > > Ok, so we will copy the

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-14 Thread Russell King - ARM Linux
On Tue, Jul 14, 2015 at 03:55:46PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jul 14, 2015 at 01:29:04PM +0100, Russell King - ARM Linux wrote: > > On Tue, Jul 14, 2015 at 12:03:02PM +0100, Lorenzo Pieralisi wrote: > > > On Tue, Jul 14, 2015 at 11:34:21AM +0100, Russell King - ARM Linux wrote: > > >

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-14 Thread Lorenzo Pieralisi
On Tue, Jul 14, 2015 at 01:29:04PM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 14, 2015 at 12:03:02PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Jul 14, 2015 at 11:34:21AM +0100, Russell King - ARM Linux wrote: > > > > +static struct cpuidle_ops psci_cpuidle_ops __initdata = { > > > > +

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-14 Thread Russell King - ARM Linux
On Tue, Jul 14, 2015 at 12:03:02PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jul 14, 2015 at 11:34:21AM +0100, Russell King - ARM Linux wrote: > > > +static struct cpuidle_ops psci_cpuidle_ops __initdata = { > > > + .suspend = cpu_psci_cpu_suspend, > > > + .init = cpu_psci_cpu_init_idle, > > > +};

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-14 Thread Lorenzo Pieralisi
On Tue, Jul 14, 2015 at 11:34:21AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 09, 2015 at 04:31:25PM +0800, Jisheng Zhang wrote: > > This patch implements cpuidle_ops using psci. After this patch, we can > > use cpuidle-arm.c with psci backend for both arm and arm64. > > > > Signed-off-b

Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend

2015-07-14 Thread Russell King - ARM Linux
On Thu, Jul 09, 2015 at 04:31:25PM +0800, Jisheng Zhang wrote: > This patch implements cpuidle_ops using psci. After this patch, we can > use cpuidle-arm.c with psci backend for both arm and arm64. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/kernel/Makefile | 1 + > arch/arm/kernel/