Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-09 Thread Steven Rostedt
On Wed, 9 Dec 2020 22:51:14 +0900 Masami Hiramatsu wrote: > This makes sense. Anyway, what I considered were > - synthetic_events interface doesn't provide syntax error reports > - synthetic_events interface is not self-reproducive*. > > *) I meant > > $ cat synthetic_events > saved_events > $

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-09 Thread Masami Hiramatsu
On Tue, 8 Dec 2020 12:53:40 -0500 Steven Rostedt wrote: > On Tue, 08 Dec 2020 11:34:41 -0600 > Tom Zanussi wrote: > > > Unfortunately, you're correct, if you have a script that creates a > > synthetic event without semicolons, this patchset will break it, as I > > myself found out and fixed in

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-08 Thread Tom Zanussi
Hi Steve, On Tue, 2020-12-08 at 12:53 -0500, Steven Rostedt wrote: > On Tue, 08 Dec 2020 11:34:41 -0600 > Tom Zanussi wrote: > > > Unfortunately, you're correct, if you have a script that creates a > > synthetic event without semicolons, this patchset will break it, as > > I > > myself found out

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-08 Thread Steven Rostedt
On Tue, 08 Dec 2020 11:34:41 -0600 Tom Zanussi wrote: > Unfortunately, you're correct, if you have a script that creates a > synthetic event without semicolons, this patchset will break it, as I > myself found out and fixed in patch 4 ([PATCH v3 4/5] selftests/ftrace: > Add synthetic event field

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-08 Thread Tom Zanussi
Hi Steve, On Mon, 2020-12-07 at 20:13 -0500, Steven Rostedt wrote: > On Mon, 26 Oct 2020 10:06:11 -0500 > Tom Zanussi wrote: > > > Since array types are handled differently, errors referencing them > > also need to be handled differently. Add and use a new > > INVALID_ARRAY_SPEC error. Also ad

Re: [PATCH v3 3/5] tracing: Update synth command errors

2020-12-07 Thread Steven Rostedt
On Mon, 26 Oct 2020 10:06:11 -0500 Tom Zanussi wrote: > Since array types are handled differently, errors referencing them > also need to be handled differently. Add and use a new > INVALID_ARRAY_SPEC error. Also add INVALID_CMD and INVALID_DYN_CMD to > catch and display the correct form for ba