Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 6:02 AM, Matti Vaittinen wrote: > Hello Chanwoo, Greg, > > Thanks for the review. > > On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote: >> Hi, >> >> Need to fix the work as following: >> s/extconn/extcon >> >> And I'd like you to use the more correct patch title like the >> f

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-23 Thread Matti Vaittinen
Hello Chanwoo, Greg, Thanks for the review. On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote: > Hi, > > Need to fix the work as following: > s/extconn/extcon > > And I'd like you to use the more correct patch title like the > following example: > "extcon: Use resource-managed function for

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-23 Thread Chanwoo Choi
Hi, Need to fix the work as following: s/extconn/extcon And I'd like you to use the more correct patch title like the following example: "extcon: Use resource-managed function for delayed work" Thanks, Chanwoo Choi On 3/23/21 10:57 PM, Matti Vaittinen wrote: > Few drivers implement remove call-

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 2:57 PM, Matti Vaittinen wrote: > Few drivers implement remove call-back only for ensuring a delayed > work gets cancelled prior driver removal. Clean-up these by switching > to use devm_delayed_work_autocancel() instead. > > Additionally, this helps avoiding mixing devm and manual