Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-14 Thread Marc Kleine-Budde
On 08/04/2014 06:01 PM, Stefan Agner wrote: > Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: >> On 08/04/2014 03:43 PM, Stefan Agner wrote: >> [...] >> Thanks for the test, so far looks promising :) With this setup the other CAN node repeats the CAN frame until it's ACKed. Because there

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-05 Thread Stefan Agner
Am 2014-08-05 11:52, schrieb Marc Kleine-Budde: > On 08/04/2014 06:01 PM, Stefan Agner wrote: >> Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: >>> On 08/04/2014 03:43 PM, Stefan Agner wrote: >>> [...] >>> > Thanks for the test, so far looks promising :) With this setup the other > CAN nod

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-05 Thread Marc Kleine-Budde
On 08/04/2014 06:01 PM, Stefan Agner wrote: > Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: >> On 08/04/2014 03:43 PM, Stefan Agner wrote: >> [...] >> Thanks for the test, so far looks promising :) With this setup the other CAN node repeats the CAN frame until it's ACKed. Because there

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-04 Thread Stefan Agner
Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: > On 08/04/2014 03:43 PM, Stefan Agner wrote: > [...] > >>> Thanks for the test, so far looks promising :) With this setup the other >>> CAN node repeats the CAN frame until it's ACKed. Because there is no >>> node with a compatible bitrate, there is

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-04 Thread Marc Kleine-Budde
On 08/04/2014 03:43 PM, Stefan Agner wrote: [...] >> Thanks for the test, so far looks promising :) With this setup the other >> CAN node repeats the CAN frame until it's ACKed. Because there is no >> node with a compatible bitrate, there is no ACking CAN node. >> >> Can you add a third CAN node t

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-04 Thread Stefan Agner
Am 2014-07-30 13:47, schrieb Marc Kleine-Budde: > On 07/29/2014 09:29 AM, Stefan Agner wrote: >> Am 2014-07-28 18:28, schrieb Marc Kleine-Budde: >>> On 07/28/2014 06:20 PM, Stefan Agner wrote: I'm not sure whether you really want to keep the FLEXCAN_CTRL_ERR_STATE commented out... >>> >>>

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-30 Thread Marc Kleine-Budde
On 07/29/2014 09:29 AM, Stefan Agner wrote: > Am 2014-07-28 18:28, schrieb Marc Kleine-Budde: >> On 07/28/2014 06:20 PM, Stefan Agner wrote: >>> I'm not sure whether you really want to keep the FLEXCAN_CTRL_ERR_STATE >>> commented out... >> >> No, please remove this change and redo the test. >> >

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-29 Thread Stefan Agner
Am 2014-07-28 18:28, schrieb Marc Kleine-Budde: > On 07/28/2014 06:20 PM, Stefan Agner wrote: >> I'm not sure whether you really want to keep the FLEXCAN_CTRL_ERR_STATE >> commented out... > > No, please remove this change and redo the test. > Ok, removed that change and did the tests again: ==

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-28 Thread Marc Kleine-Budde
On 07/28/2014 06:20 PM, Stefan Agner wrote: >>> Ping. Anything open/to do from my side? >> >> Please keep the printing of esr and ctrl in the interrupt handler, add a >> #define DEBUG in the driver, but do not change anything else. Then: ^

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-28 Thread Marc Kleine-Budde
On 07/28/2014 06:20 PM, Stefan Agner wrote: [...] > However, I got once this Kernel panic after I reconfigured to normal > mode. But I could not reproduce this. > > [ 461.954394] flexcan_irq, esr=00059d82 > [ 461.958093] flexcan_irq, ctrl=17092051 > [ 461.961873] [ cut here ]--

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-28 Thread Stefan Agner
Am 2014-07-25 15:33, schrieb Marc Kleine-Budde: > On 07/25/2014 12:50 PM, Stefan Agner wrote: >> Am 2014-07-16 08:43, schrieb Stefan Agner: >>> Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: >>> > @@ -150,18 +171,20 @@ > * FLEXCAN hardware feature flags > * > * Below is some

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-25 Thread Marc Kleine-Budde
On 07/25/2014 12:50 PM, Stefan Agner wrote: > Am 2014-07-16 08:43, schrieb Stefan Agner: >> Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: >> @@ -150,18 +171,20 @@ * FLEXCAN hardware feature flags * * Below is some version info we got: - *SOC Version IP-Vers

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-25 Thread Stefan Agner
Am 2014-07-16 08:43, schrieb Stefan Agner: > Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: > >>> @@ -150,18 +171,20 @@ >>> * FLEXCAN hardware feature flags >>> * >>> * Below is some version info we got: >>> - *SOC Version IP-Version Glitch- [TR]WRN_INT >>> - *

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-15 Thread Stefan Agner
Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: >> @@ -150,18 +171,20 @@ >> * FLEXCAN hardware feature flags >> * >> * Below is some version info we got: >> - *SOC Version IP-Version Glitch- [TR]WRN_INT >> - *Filter? connected? >> - * MX25 FlexC

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-15 Thread Marc Kleine-Budde
On 07/15/2014 02:56 PM, Stefan Agner wrote: > Extend FlexCAN driver to support Vybrid. Vybrids variant of the IP > has ECC support which is controlled through the memory error > control register (MECR). There is also an errata which leads to > false positive error detections (ID e5295). This patch