Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-06 Thread grygorii.stras...@linaro.org
On 04/06/2015 07:09 PM, Wolfram Sang wrote: Of course, i2c_davinci_wait_bus_not_busy() has to be fixed first as proposed by Alexander Sverdlin here: https://patchwork.ozlabs.org/patch/448994/. Okay, good that you said it. So I'll give his patch series priority over this one. Sorry, but

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-06 Thread Wolfram Sang
> >> Of course, i2c_davinci_wait_bus_not_busy() has to be fixed first > >> as proposed by Alexander Sverdlin here: > >> https://patchwork.ozlabs.org/patch/448994/. > > > > Okay, good that you said it. So I'll give his patch series priority over > > this one. > > > Sorry, but this series alre

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-06 Thread grygorii.stras...@linaro.org
On 04/03/2015 11:18 PM, Wolfram Sang wrote: > >>> The I2C specs say in 3.1.16 that the recovery procedure should be used >>> when SDA is stuck low. So, I do wonder if we should apply the recovery >>> after a timeout. Stuck SDA might be one reason for timeout, but there >>> may be others... >> >> T

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-03 Thread Wolfram Sang
> > The I2C specs say in 3.1.16 that the recovery procedure should be used > > when SDA is stuck low. So, I do wonder if we should apply the recovery > > after a timeout. Stuck SDA might be one reason for timeout, but there > > may be others... > > This is ancient code. And regarding your questio

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-03-20 Thread grygorii.stras...@linaro.org
Hi, On 03/18/2015 10:31 PM, Wolfram Sang wrote: > Hi, > > so, the bus recovery patches look fine to me in general. > > It is only this one question left which I always had with bus recovery. > Maybe you guys can join me thinking about it. Ok. Thanks and sorry for delayed reply - missed your e-ma

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-03-18 Thread Wolfram Sang
Hi, so, the bus recovery patches look fine to me in general. It is only this one question left which I always had with bus recovery. Maybe you guys can join me thinking about it. > @@ -376,8 +366,7 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct > i2c_msg *msg, int stop) >

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-03-12 Thread Alexander Sverdlin
Hello Grygorii, On 01/12/14 16:34, Grygorii Strashko wrote: > This patch converts Davinci I2C driver to use I2C bus recovery > infrastructure, introduced by commit 5f9296ba21b3 ("i2c: Add > bus recovery infrastructure"). > > The i2c_bus_recovery_info is configured for Davinci I2C adapter > only i