Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
calling out some thinkos On Thu, Jun 11, 2020 at 3:19 PM wrote: > > heres what I have in mind. whats described here is working. > I'll send it out soon > > commit 20298ec88cc2ed64269c8be7b287a24e60a5347e > Author: Jim Cromie > Date: Wed Jun 10 12:55:08 2020 -0600 > > dyndbg: WIP towards m

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Joe Perches
On Thu, 2020-06-11 at 17:59 -0400, Jason Baron wrote: > > On 6/11/20 5:19 PM, jim.cro...@gmail.com wrote: > > trimmed.. > > > > > > > Currently I think there not enough "levels" to map something like > > > > > drm.debug to the new dyn dbg feature. I don't think it is intrinsic > > > > > but I cou

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Jason Baron
On 6/11/20 5:19 PM, jim.cro...@gmail.com wrote: > trimmed.. > Currently I think there not enough "levels" to map something like drm.debug to the new dyn dbg feature. I don't think it is intrinsic but I couldn't find the bit of the code where the 5-bit level in struct _ddebug

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
trimmed.. > > > Currently I think there not enough "levels" to map something like > > > drm.debug to the new dyn dbg feature. I don't think it is intrinsic > > > but I couldn't find the bit of the code where the 5-bit level in struct > > > _ddebug is converted from a mask to a bit number and vice-

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Daniel Thompson
On Thu, Jun 11, 2020 at 02:31:07PM +0300, Stanimir Varbanov wrote: > On 6/11/20 1:52 PM, Daniel Thompson wrote: > > On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: > >> On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > >>> On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perc

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Stanimir Varbanov
On 6/11/20 1:52 PM, Daniel Thompson wrote: > On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: >> On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: >>> On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: >>>

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Daniel Thompson
On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: > On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > > > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kr

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > > > Please work with the infrastructure we hav

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > > Please work with the infrastructure we have, we have spent a lot of time > > > and effort to make it uniform to

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > Please work with the infrastructure we have, we have spent a lot of time > > and effort to make it uniform to make it easier for users and > > developers. > > Not quite. > > Th

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > Please work with the infrastructure we have, we have spent a lot of time > and effort to make it uniform to make it easier for users and > developers. Not quite. This lack of debug grouping by type has been a _long_ standing issue wit

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2020 at 04:29:27PM +0300, Stanimir Varbanov wrote: > > > On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote: > > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: > >> Here we introduce few debug macros with levels (low, medium and > >> high) and debug macro for firmware

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Stanimir Varbanov
On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: >> Here we introduce few debug macros with levels (low, medium and >> high) and debug macro for firmware. Enabling the particular level >> will be done by dynamic debug with levels.

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-09 Thread Greg Kroah-Hartman
On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: > Here we introduce few debug macros with levels (low, medium and > high) and debug macro for firmware. Enabling the particular level > will be done by dynamic debug with levels. > > For example to enable debug messages with low le