Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread Paolo Bonzini
Il 25/05/2013 06:14, James Bottomley ha scritto: > On Fri, 2013-05-24 at 10:32 +0200, Paolo Bonzini wrote: >> Il 24/05/2013 10:03, James Bottomley ha scritto: >>> Does anyone in the real world actually care about this bug? > > Yes, or I would move on and not waste so much ti

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 10:32 +0200, Paolo Bonzini wrote: > Il 24/05/2013 10:03, James Bottomley ha scritto: > > > >>> Does anyone in the real world actually care about this bug? > > >> > > >> Yes, or I would move on and not waste so much time on this. > >>> > > > >>> > > Fine, so prod

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 10:32, Paolo Bonzini ha scritto: > Il 24/05/2013 10:03, James Bottomley ha scritto: >> Does anyone in the real world actually care about this bug? Yes, or I would move on and not waste so much time on this. >> >> Fine, so produce a simple fix for this

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 10:03, James Bottomley ha scritto: > > >>> Does anyone in the real world actually care about this bug? > >> > >> Yes, or I would move on and not waste so much time on this. >>> > > >>> > > Fine, so produce a simple fix for this bug which we can discuss that's >>> > > no

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:53 +0200, Paolo Bonzini wrote: > Il 24/05/2013 09:50, James Bottomley ha scritto: > > On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: > >> Il 24/05/2013 09:36, James Bottomley ha scritto: > >>> On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: > Adjust th

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 09:50, James Bottomley ha scritto: > On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: >> Il 24/05/2013 09:36, James Bottomley ha scritto: >>> On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: Adjust the blk_verify_command function to let it look at per-queue dat

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: > Il 24/05/2013 09:36, James Bottomley ha scritto: > > On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: > >> Adjust the blk_verify_command function to let it look at per-queue > >> data. This will be done in the next patch. > > > > Th

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 09:36, James Bottomley ha scritto: > On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: >> Adjust the blk_verify_command function to let it look at per-queue >> data. This will be done in the next patch. > > This is not a bug fix. This is an enabler for your complex and to my

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: > Adjust the blk_verify_command function to let it look at per-queue > data. This will be done in the next patch. This is not a bug fix. This is an enabler for your complex and to my mind dubious rework of the SG_IO command filter. I'm run