Re: [PATCH v3.5 10/19] mac8011: slight optimization of addr compare

2014-01-06 Thread Ding Tianhong
On 2014/1/6 23:11, Johannes Berg wrote: > On Thu, 2013-12-26 at 19:40 +0800, Ding Tianhong wrote: >> Use the possibly more efficient ether_addr_equal >> to instead of memcmp. > > This is a slow-path, I don't think that's really worth it. It kinda > makes sense, but relies on the struct mac_address

Re: [PATCH v3.5 10/19] mac8011: slight optimization of addr compare

2014-01-06 Thread Johannes Berg
On Thu, 2013-12-26 at 19:40 +0800, Ding Tianhong wrote: > Use the possibly more efficient ether_addr_equal > to instead of memcmp. This is a slow-path, I don't think that's really worth it. It kinda makes sense, but relies on the struct mac_address allocation for alignment and the fact that there