Re: [PATCH v4] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator

2012-08-24 Thread jonghwa3 . lee
On 2012년 08월 24일 16:47, jonghwa3@samsung.com wrote: > On 2012년 08월 24일 11:07, Mike Turquette wrote: >>> + struct clk *clk; >>> + >>> + clk = clk_register(dev, clk_name[clk_id], &clk_max77686_ops, >>> + &max77686->hw, NULL, 0, CLK_IS_ROOT); >>> + >>> +

Re: [PATCH v4] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator

2012-08-24 Thread jonghwa3 . lee
Hi Mike, On 2012년 08월 24일 11:07, Mike Turquette wrote: > Hello Jonghwa, > > Quoting Jonghwa Lee (2012-06-27 03:31:17) >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > Please use clk-provider.h. I don't see any reason for this code to need > clk-p

Re: [PATCH v4] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator

2012-08-23 Thread Mike Turquette
Hello Jonghwa, Quoting Jonghwa Lee (2012-06-27 03:31:17) > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please use clk-provider.h. I don't see any reason for this code to need clk-private.h. > +#include > +#include > + > +#defineMAX77686_CLK