Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread David E. Box
On Wed, 2021-04-07 at 09:31 +, Winkler, Tomas wrote: > > > > Hi, > > > > On 4/7/21 8:51 AM, Winkler, Tomas wrote: > > > > > > > > > > During PCH (platform/board) manufacturing process a global > > > > > reset has > > > > > to be induced in order for configuration changes take the > > > > >

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 11:31 AM, Winkler, Tomas wrote: > > >> Hi, >> >> On 4/7/21 8:51 AM, Winkler, Tomas wrote: > > During PCH (platform/board) manufacturing process a global reset has > to be induced in order for configuration changes take the effect > upon following platform reset. >>>

RE: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Winkler, Tomas
> Hi, > > On 4/7/21 8:51 AM, Winkler, Tomas wrote: > >>> > >>> During PCH (platform/board) manufacturing process a global reset has > >>> to be induced in order for configuration changes take the effect > >>> upon following platform reset. > >>> This setting was commonly done by accessing PMC re

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 8:51 AM, Winkler, Tomas wrote: >>> >>> During PCH (platform/board) manufacturing process a global reset has >>> to be induced in order for configuration changes take the effect upon >>> following platform reset. >>> This setting was commonly done by accessing PMC registers via /dev/m

RE: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread Winkler, Tomas
> > > > During PCH (platform/board) manufacturing process a global reset has > > to be induced in order for configuration changes take the effect upon > > following platform reset. > > This setting was commonly done by accessing PMC registers via /dev/mem > > but due to security concern /dev/mem ac

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread David E. Box
Hi Tomas, On Tue, 2021-04-06 at 15:11 +0200, Hans de Goede wrote: > Hi, > > On 4/2/21 5:21 PM, Tomas Winkler wrote: > > From: Tamar Mashiah > > > > During PCH (platform/board) manufacturing process a global reset > > has to be induced in order for configuration changes take the effect > > upon

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread Hans de Goede
Hi, On 4/2/21 5:21 PM, Tomas Winkler wrote: > From: Tamar Mashiah > > During PCH (platform/board) manufacturing process a global reset > has to be induced in order for configuration changes take the effect > upon following platform reset. > This setting was commonly done by accessing PMC registe

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread David E. Box
Hi Tomas, I have a patch set that also adds the ETR3 register, although for an entirely different purpose. It doesn't touch the same bits. But your patch can be taken as is. I'll rebase on top of this one. Thanks. Reviewed-by: David E Box On Fri, 2021-04-02 at 18:21 +0300, Tomas Winkler wrote: