Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread Kees Cook
On Tue, Apr 30, 2019 at 9:30 AM Matteo Croce wrote: > > On Tue, Apr 30, 2019 at 6:08 PM Matthew Wilcox wrote: > > > > On Tue, Apr 30, 2019 at 08:42:42AM -0700, Kees Cook wrote: > > > On Tue, Apr 30, 2019 at 3:47 AM Matteo Croce wrote: > > > > On Tue, Apr 30, 2019 at 12:26 AM Matteo Croce wrote:

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread Matteo Croce
On Tue, Apr 30, 2019 at 6:08 PM Matthew Wilcox wrote: > > On Tue, Apr 30, 2019 at 08:42:42AM -0700, Kees Cook wrote: > > On Tue, Apr 30, 2019 at 3:47 AM Matteo Croce wrote: > > > On Tue, Apr 30, 2019 at 12:26 AM Matteo Croce wrote: > > > > > > > > Add a const int array containing the most common

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread Matthew Wilcox
On Tue, Apr 30, 2019 at 08:42:42AM -0700, Kees Cook wrote: > On Tue, Apr 30, 2019 at 3:47 AM Matteo Croce wrote: > > On Tue, Apr 30, 2019 at 12:26 AM Matteo Croce wrote: > > > > > > Add a const int array containing the most commonly used values, > > > some macros to refer more easily to the corre

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread Kees Cook
On Tue, Apr 30, 2019 at 3:47 AM Matteo Croce wrote: > > On Tue, Apr 30, 2019 at 12:26 AM Matteo Croce wrote: > > > > Add a const int array containing the most commonly used values, > > some macros to refer more easily to the correct array member, > > and use them instead of creating a local one f

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v5.1-rc7] [cannot apply to next-20190429] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://git

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-30 Thread Matteo Croce
On Tue, Apr 30, 2019 at 12:26 AM Matteo Croce wrote: > > Add a const int array containing the most commonly used values, > some macros to refer more easily to the correct array member, > and use them instead of creating a local one for every object file. > Ok it seems that this simply can't be do

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-29 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v5.1-rc7] [cannot apply to next-20190429] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://git

Re: [PATCH v4] proc/sysctl: add shared variables for range check

2019-04-29 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v5.1-rc7] [cannot apply to next-20190429] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://git