Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Hu Yaohui
Hi Guangrong, Thanks a lot! I will reopen a new discussion next time. Does that means once the level 1 guest page table entry is modified, the host should make a decision in page fault handler whether the page sync or unsync? My question is that since all level 1 guest page tables are writable, whe

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Xiao Guangrong
On 03/26/2014 12:40 PM, Hu Yaohui wrote: > Hi all, > I hope you have a good day! > I have debugged the code myself. I have called dump_stack() in > function "__kvm_unsync_page" > and function "invlpg". Actually every time before invlpg is called, > the page fault handled will call "__kvm_unsync_pa

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Xiao Guangrong
A suggestion: please send a new mail to ask question, especially, when your question is not related to the patches, so that others will probably discover the topic and join the discussion. On 03/26/2014 12:25 AM, Hu Yaohui wrote: > Hi Guangrong, > Since you have written in the kvm/mmu.txt. > >

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Hu Yaohui
Hi all, I hope you have a good day! I have debugged the code myself. I have called dump_stack() in function "__kvm_unsync_page" and function "invlpg". Actually every time before invlpg is called, the page fault handled will call "__kvm_unsync_page" before invlpg to mark the specified sp as unsynce

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Hu Yaohui
Hi Guangrong, Since you have written in the kvm/mmu.txt. unsync: If true, then the translations in this page may not match the guest's translation. This is equivalent to the state of the tlb when a pte is changed but before the tlb entry is flushed. Accordingly, unsync ptes ar

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-25 Thread Paolo Bonzini
Il 25/03/2014 04:29, Xiao Guangrong ha scritto: Ping.. Hi Xiao, I'll look at these patches soon. I plan to merge them for 3.16. Paolo On 03/10/2014 10:01 PM, Xiao Guangrong wrote: This patchset is splited from my previous patchset: [PATCH v3 00/15] KVM: MMU: locklessly write-protect th

Re: [PATCH v4 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-03-24 Thread Xiao Guangrong
Ping.. On 03/10/2014 10:01 PM, Xiao Guangrong wrote: > This patchset is splited from my previous patchset: > [PATCH v3 00/15] KVM: MMU: locklessly write-protect > that can be found at: > https://lkml.org/lkml/2013/10/23/265 > > Changelog v4 : > - add more comments for patch 5 and thank for M