Re: [PATCH v4 00/25] Page folios

2021-03-18 Thread Matthew Wilcox
On Fri, Mar 05, 2021 at 04:18:36AM +, Matthew Wilcox (Oracle) wrote: > Our type system does not currently distinguish between tail pages and > head or single pages. This is a problem because we call compound_head() > multiple times (and the compiler cannot optimise it out), bloating the >

Re: [PATCH v4 00/25] Page folios

2021-03-17 Thread Christoph Hellwig
On Mon, Mar 15, 2021 at 07:40:14PM +, Matthew Wilcox wrote: > The reason I didn't go with 'head' is that traditionally 'head' implies > that there are tail pages. It would be weird to ask 'if (HeadHead(head))' > That's currently spelled 'if (FolioMulti(folio))'. But it can be changed > if

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Dave Chinner
On Mon, Mar 15, 2021 at 07:40:14PM +, Matthew Wilcox wrote: > I would agree that the conversion is both straightforward and noisy. > There are some minor things that crop up, like noticing that we get > the accounting wrong for writeback of compound pages. That's not > entirely unexpected

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Andi Kleen
Michal Hocko writes: > bikeshedding) because it hasn't really resonated with the udnerlying > concept. Maybe just me as a non native speaker... page_head would have > been so much more straightforward but not something I really care > about. Yes. page_head explains exactly what it is. But

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Matthew Wilcox
On Mon, Mar 15, 2021 at 07:09:04PM +, Christoph Hellwig wrote: > On Mon, Mar 15, 2021 at 01:38:04PM +0100, Michal Hocko wrote: > > I tend to agree here as well. The level compoud_head has spread out > > silently is just too large. There are people coming up with all sorts of > > optimizations

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Christoph Hellwig
On Mon, Mar 15, 2021 at 01:38:04PM +0100, Michal Hocko wrote: > I tend to agree here as well. The level compoud_head has spread out > silently is just too large. There are people coming up with all sorts of > optimizations to workaround that, and they are quite right that this is > somehing worth

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Matthew Wilcox
On Mon, Mar 15, 2021 at 02:55:01PM +0300, Kirill A. Shutemov wrote: > I'm with Matthew on this. I would really want to drop the number of places > where we call compoud_head(). I hope we can get rid of the page flag > policy hack I made. I can't see that far ahead too clearly, but I do think that

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Michal Hocko
On Mon 15-03-21 14:55:01, Kirill A. Shutemov wrote: > On Sat, Mar 13, 2021 at 07:09:01PM -0800, Hugh Dickins wrote: > > On Sat, 13 Mar 2021, Andrew Morton wrote: > > > On Fri, 5 Mar 2021 04:18:36 + "Matthew Wilcox (Oracle)" > > > wrote: > > > > > > > Our type system does not currently

Re: [PATCH v4 00/25] Page folios

2021-03-15 Thread Kirill A. Shutemov
On Sat, Mar 13, 2021 at 07:09:01PM -0800, Hugh Dickins wrote: > On Sat, 13 Mar 2021, Andrew Morton wrote: > > On Fri, 5 Mar 2021 04:18:36 + "Matthew Wilcox (Oracle)" > > wrote: > > > > > Our type system does not currently distinguish between tail pages and > > > head or single pages. This

Re: [PATCH v4 00/25] Page folios

2021-03-13 Thread Hugh Dickins
On Sat, 13 Mar 2021, Andrew Morton wrote: > On Fri, 5 Mar 2021 04:18:36 + "Matthew Wilcox (Oracle)" > wrote: > > > Our type system does not currently distinguish between tail pages and > > head or single pages. This is a problem because we call compound_head() > > multiple times (and the

Re: [PATCH v4 00/25] Page folios

2021-03-13 Thread Matthew Wilcox
On Sat, Mar 13, 2021 at 12:36:58PM -0800, Andrew Morton wrote: > On Fri, 5 Mar 2021 04:18:36 + "Matthew Wilcox (Oracle)" > wrote: > > > Our type system does not currently distinguish between tail pages and > > head or single pages. This is a problem because we call compound_head() > >

Re: [PATCH v4 00/25] Page folios

2021-03-13 Thread Andrew Morton
On Fri, 5 Mar 2021 04:18:36 + "Matthew Wilcox (Oracle)" wrote: > Our type system does not currently distinguish between tail pages and > head or single pages. This is a problem because we call compound_head() > multiple times (and the compiler cannot optimise it out), bloating the >