On Fri, Feb 08, 2019 at 04:18:40PM -0500, Stefan Berger wrote:
> On 2/8/19 3:46 PM, Jarkko Sakkinen wrote:
> > On Fri, Feb 08, 2019 at 03:32:32PM -0500, Stefan Berger wrote:
> > >
> > > tpm_del_char_device also needs the start/stop!
> > Done and updated the commit message to have all the call site
On 2/8/19 3:46 PM, Jarkko Sakkinen wrote:
On Fri, Feb 08, 2019 at 03:32:32PM -0500, Stefan Berger wrote:
tpm_del_char_device also needs the start/stop!
Done and updated the commit message to have all the call sites:
* tpm_chip_register()
* tpm_class_shutdown()
* tpm_del_char_de
On Fri, Feb 08, 2019 at 03:32:32PM -0500, Stefan Berger wrote:
> On 2/8/19 3:23 PM, Jarkko Sakkinen wrote:
> > On Fri, Feb 08, 2019 at 02:27:31PM -0500, Stefan Berger wrote:
> > > On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
> > > >*/
> > > > if (rc > 0) {
> > > > dev_warn(&chip->dev,
> >
On Fri, Feb 08, 2019 at 10:23:53PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 08, 2019 at 02:27:31PM -0500, Stefan Berger wrote:
> > On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
> > >
> > > */
> > > if (rc > 0) {
> > > dev_warn(&chip->dev,
> > >"%s: send(): invalid value %d\n", __fun
On 2/8/19 3:23 PM, Jarkko Sakkinen wrote:
On Fri, Feb 08, 2019 at 02:27:31PM -0500, Stefan Berger wrote:
On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
*/
if (rc > 0) {
dev_warn(&chip->dev,
"%s: send(): invalid value %d\n", __func__, rc);
rc = 0;
}
Should be fair
On Fri, Feb 08, 2019 at 02:27:31PM -0500, Stefan Berger wrote:
> On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
> >
> > */
> > if (rc > 0) {
> > dev_warn(&chip->dev,
> > "%s: send(): invalid value %d\n", __func__, rc);
> > rc = 0;
> > }
> >
> > Should be fairly safe play now.
>
On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
*/
if (rc > 0) {
dev_warn(&chip->dev,
"%s: send(): invalid value %d\n", __func__, rc);
rc = 0;
}
Should be fairly safe play now.
Unfortuantely it isn't. You seemed to have lost the
EXPORT_SYMBOL_GPL(tpm_chip_start/s
On Fri, Feb 08, 2019 at 09:00:57PM +0200, Jarkko Sakkinen wrote:
> It all looks now legit, but just in case I'll add a check for the return
> value to tpm_try_transmit() and a warning if it is not zero in the
> success case (and after that zeroing of rc).
Now the commits are applied both master an
8 matches
Mail list logo
