Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Romain Perier
Hi, > So,do you mean that I should rename the C source file as phy-rockchip-usb2.c > ? what I mean is that you can simply rename the kconfig entry to PHY_ROCKCHIP_USB. If you explain that it is for usb 2.0 in the description (as it is already the case), it is enough, no needs to put USB2 in the

Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Yunzhi Li
Hi Romain: On 2014/12/9 18:41, Romain Perier wrote: Hi, 2014-12-09 3:43 GMT+01:00 Yunzhi Li : Changes in v3: - Use BIT macro instead of bit shift ops. - Rename the config entry to PHY_ROCKCHIP_USB. Contradiction between this , [1] and [2] drivers/phy/Kconfig| 7 ++

Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Yunzhi Li
Hi Romain: On 2014/12/9 18:41, Romain Perier wrote: Hi, 2014-12-09 3:43 GMT+01:00 Yunzhi Li l...@rock-chips.com: Changes in v3: - Use BIT macro instead of bit shift ops. - Rename the config entry to PHY_ROCKCHIP_USB. Contradiction between this , [1] and [2] drivers/phy/Kconfig

Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Romain Perier
Hi, So,do you mean that I should rename the C source file as phy-rockchip-usb2.c ? what I mean is that you can simply rename the kconfig entry to PHY_ROCKCHIP_USB. If you explain that it is for usb 2.0 in the description (as it is already the case), it is enough, no needs to put USB2 in the

Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-09 Thread Romain Perier
Hi, 2014-12-09 3:43 GMT+01:00 Yunzhi Li : > Changes in v3: > - Use BIT macro instead of bit shift ops. > - Rename the config entry to PHY_ROCKCHIP_USB. Contradiction between this , [1] and [2] > > drivers/phy/Kconfig| 7 ++ > drivers/phy/Makefile | 1 + >

Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-09 Thread Romain Perier
Hi, 2014-12-09 3:43 GMT+01:00 Yunzhi Li l...@rock-chips.com: Changes in v3: - Use BIT macro instead of bit shift ops. - Rename the config entry to PHY_ROCKCHIP_USB. Contradiction between this , [1] and [2] drivers/phy/Kconfig| 7 ++ drivers/phy/Makefile | 1 +