Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-08-10 Thread Sylwester Nawrocki
On 08/09/2016 10:50 PM, Lee Jones wrote: > On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > >> > On 08/09/2016 05:05 PM, Lee Jones wrote: > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, > > >> > + exynos_lpass_resume); >>> > > Put this u

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-08-10 Thread Lee Jones
On Wed, 10 Aug 2016, Sylwester Nawrocki wrote: > On 08/09/2016 10:50 PM, Lee Jones wrote: > > On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > > > >> > On 08/09/2016 05:05 PM, Lee Jones wrote: > > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, > > > >> > +

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-08-09 Thread Lee Jones
On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > On 08/09/2016 05:05 PM, Lee Jones wrote: > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, > >> > +exynos_lpass_resume); > > Put this up by the PM functions. > > Sorry, I don't understand thi

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-08-09 Thread Sylwester Nawrocki
On 08/09/2016 05:05 PM, Lee Jones wrote: >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, >> > + exynos_lpass_resume); > Put this up by the PM functions. Sorry, I don't understand this comment, which PM functions do you mean exactly? -- Thanks, Sy

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-08-09 Thread Lee Jones
On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > This patch adds common driver for the Top block of the Samsung Exynos > SoC Low Power Audio Subsystem. This is a minimal driver which prepares > resources for IP blocks like I2S, audio DMA and UART and exposes a regmap > for the Top block registers.

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-07-21 Thread Lee Jones
On Wed, 20 Jul 2016, Sylwester Nawrocki wrote: > On 07/05/2016 07:13 PM, Sylwester Nawrocki wrote: > > This patch adds common driver for the Top block of the Samsung Exynos > > SoC Low Power Audio Subsystem. This is a minimal driver which prepares > > resources for IP blocks like I2S, audio DMA an

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

2016-07-20 Thread Sylwester Nawrocki
On 07/05/2016 07:13 PM, Sylwester Nawrocki wrote: > This patch adds common driver for the Top block of the Samsung Exynos > SoC Low Power Audio Subsystem. This is a minimal driver which prepares > resources for IP blocks like I2S, audio DMA and UART and exposes a regmap > for the Top block register