Re: [linux-sunxi] Re: [PATCH v4 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-18 Thread Brüns , Stefan
On Freitag, 18. Mai 2018 09:14:36 CEST Maxime Ripard wrote: > On Mon, May 14, 2018 at 10:36:08PM +0200, Paul Kocialkowski wrote: > > > > + backlight: backlight { > > > > + compatible = "pwm-backlight"; > > > > + pwms = <&pwm 0 5 PWM_POLARITY_INVERTED>; > > > >

Re: [PATCH v4 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-18 Thread Maxime Ripard
On Mon, May 14, 2018 at 10:36:08PM +0200, Paul Kocialkowski wrote: > > > + backlight: backlight { > > > + compatible = "pwm-backlight"; > > > + pwms = <&pwm 0 5 PWM_POLARITY_INVERTED>; > > > + brightness-levels = < 0 1 1 1 1 2 2 2 > > > +

Re: [PATCH v4 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-14 Thread Paul Kocialkowski
Hi and thanks for the review! Le vendredi 11 mai 2018 à 16:36 +0200, Maxime Ripard a écrit : > On Tue, May 08, 2018 at 12:04:13AM +0200, Paul Kocialkowski wrote: > > +++ b/arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts > > @@ -0,0 +1,297 @@ > > +/* > > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) >

Re: [PATCH v4 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-11 Thread Maxime Ripard
On Tue, May 08, 2018 at 12:04:13AM +0200, Paul Kocialkowski wrote: > +++ b/arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts > @@ -0,0 +1,297 @@ > +/* > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) This really should be the first line, and with a C++ style comment, as in: // SPDX-License-Identifier: (G