Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-23 Thread Namjae Jeon
2012/10/23, OGAWA Hirofumi : > Namjae Jeon writes: > >>>And this is doing same >>> thing with readdir, so we will have to clean this up as I said before. >> When I checked, I didn't understand about same thing readdir and this >> function yet. Because even though minor conditions match but >> func

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-23 Thread OGAWA Hirofumi
Namjae Jeon writes: >>And this is doing same >> thing with readdir, so we will have to clean this up as I said before. > When I checked, I didn't understand about same thing readdir and this > function yet. Because even though minor conditions match but > functionality wise both are different. H

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-23 Thread Namjae Jeon
2012/10/13, OGAWA Hirofumi : > Namjae Jeon writes: > >> +if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { >> +parent_logstart = fat_get_start(sbi, de); >> parent_inode = fat_dget(sb, parent_logstart); >> +if (parent_inode || sbi->options.nf

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-15 Thread Namjae Jeon
2012/10/15 OGAWA Hirofumi : > Namjae Jeon writes: > >>> OK, I think I got where is wrong. If it is the subdir of rootdir, >>> fat_dget() should get the inode of root? >> That is correct. Whenever fat_dget() is called for sub-directories >> which is in root folder, we assign root inode as parent in

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-15 Thread OGAWA Hirofumi
Namjae Jeon writes: >> OK, I think I got where is wrong. If it is the subdir of rootdir, >> fat_dget() should get the inode of root? > That is correct. Whenever fat_dget() is called for sub-directories > which is in root folder, we assign root inode as parent inode. >> >> So, I guess if parent_lo

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-15 Thread Namjae Jeon
2012/10/14, OGAWA Hirofumi : > Namjae Jeon writes: > >> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) >> { >> + parent_logstart = fat_get_start(sbi, de); >> parent_inode = fat_dget(sb, parent_logstart); >> + if (pare

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread OGAWA Hirofumi
Namjae Jeon writes: > + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { > + parent_logstart = fat_get_start(sbi, de); > parent_inode = fat_dget(sb, parent_logstart); > + if (parent_inode || sbi->options.nfs != FAT_NFS_NOS

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread Namjae Jeon
2012/10/13 OGAWA Hirofumi : > Namjae Jeon writes: > >> 2012/10/13 OGAWA Hirofumi : >>> Namjae Jeon writes: >>> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { + parent_logstart = fat_get_start(sbi, de); parent_inode = fat_dget(sb, p

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2012/10/13 OGAWA Hirofumi : >> Namjae Jeon writes: >> >>> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { >>> + parent_logstart = fat_get_start(sbi, de); >>> parent_inode = fat_dget(sb, parent_logstart); >>> + if

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread Namjae Jeon
2012/10/13 OGAWA Hirofumi : > Namjae Jeon writes: > >> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { >> + parent_logstart = fat_get_start(sbi, de); >> parent_inode = fat_dget(sb, parent_logstart); >> + if (parent_inode || sbi->options

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread OGAWA Hirofumi
Namjae Jeon writes: > + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { > + parent_logstart = fat_get_start(sbi, de); > parent_inode = fat_dget(sb, parent_logstart); > + if (parent_inode || sbi->options.nfs != FAT_NFS_NOSTALE_RO) > +