Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-19 Thread Kevin Tang
Hi, Maxime Ripard 于2021年4月15日周四 下午5:03写道: > > Hi, > > On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > > +static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm, > > > > + struct drm_plane *primary) > > > > +{

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Maxime Ripard
Hi, On Fri, Apr 09, 2021 at 09:35:07PM +0800, Kevin Tang wrote: > > > > > + } > > > > > + > > > > > + return MODE_OK; > > > > > +} > > > > > + > > > > > +static void sprd_crtc_atomic_enable(struct drm_crtc *crtc, > > > > > +struct drm_atomic_state *state) >

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Maxime Ripard
Hi, On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > +static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm, > > > + struct drm_plane *primary) > > > +{ > > > + struct device_node *port; > > > + struct s

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Kevin Tang
Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > Hi, > > On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > > > Cc: Orson Zhai > >

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-08 Thread Thomas Zimmermann
Hi, please see my comments below. Best regards Thomas Am 22.02.21 um 14:28 schrieb Kevin Tang: Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-07 Thread Chunyan Zhang
On Wed, 7 Apr 2021 at 18:45, Maxime Ripard wrote: > > Hi, > > Adding Jörg, Will and Robin, You forgot to add them actually :) I've added Robin and Joerg. > > On Wed, Mar 31, 2021 at 09:21:19AM +0800, Kevin Tang wrote: > > > > +static u32 check_mmu_isr(struct sprd_dpu *dpu, u32 reg_val) > > > > +

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-07 Thread Maxime Ripard
Hi, Adding Jörg, Will and Robin, On Wed, Mar 31, 2021 at 09:21:19AM +0800, Kevin Tang wrote: > > > +static u32 check_mmu_isr(struct sprd_dpu *dpu, u32 reg_val) > > > +{ > > > + struct dpu_context *ctx = &dpu->ctx; > > > + u32 mmu_mask = BIT_DPU_INT_MMU_VAOR_RD | > > > +

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-03-24 Thread Maxime Ripard
Hi, On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > > v2