Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-23 Thread Jonathan Cameron
On Tue, 12 Nov 2024 18:11:37 -0500 Aren wrote: > On Tue, Nov 12, 2024 at 11:15:54AM +0100, Uwe Kleine-König wrote: > > Hello Andy, hello Aren, > > > > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > > On Sun,

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-12 Thread Aren
On Tue, Nov 12, 2024 at 11:15:54AM +0100, Uwe Kleine-König wrote: > Hello Andy, hello Aren, > > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > > >

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-12 Thread Nuno Sá
On Tue, 2024-11-12 at 11:15 +0100, Uwe Kleine-König wrote: > Hello Andy, hello Aren, > > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > > > Sun, No

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-12 Thread Andy Shevchenko
On Tue, Nov 12, 2024 at 12:15 PM Uwe Kleine-König wrote: > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > > > Sun, Nov 10, 2024 at 02:14:24PM -0500

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-12 Thread Uwe Kleine-König
Hello Andy, hello Aren, On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > > Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti: > > You can do it diff

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-11 Thread Andy Shevchenko
On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > > Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti: > > > On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote: > > > > On Sat, Nov 02, 2024 at 03:50:41PM -0400

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-10 Thread Aren
On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote: > Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti: > > On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote: > > ... > > > > > #define STK3310_RE

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-10 Thread Andy Shevchenko
Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti: > On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote: > > On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote: ... > > > #define STK3310_REGFIELD(name) > > > \ > > > do

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-10 Thread Aren
On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote: > On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote: > > Using dev_err_probe instead of dev_err and return makes the errors > > easier to understand by including the error name, and saves a little > > code. > > ... > > >

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-04 Thread Andy Shevchenko
On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote: > Using dev_err_probe instead of dev_err and return makes the errors > easier to understand by including the error name, and saves a little > code. ... > #define STK3310_REGFIELD(name) >