Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-29 Thread Jonathan Neuschäfer
On Fri, Nov 27, 2020 at 03:23:25PM +0100, Uwe Kleine-König wrote: [...] > I suggest for now we go for "don't provide a .get_state() callback" > because in the only case where it is currently called there is no cached > data to rely on anyhow. Alright! Thanks, Jonathan signature.asc Description

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-29 Thread Jonathan Neuschäfer
On Fri, Nov 27, 2020 at 08:11:05AM +0100, Uwe Kleine-König wrote: > Hello Jonathan, > > On Fri, Nov 27, 2020 at 12:19:31AM +0100, Jonathan Neuschäfer wrote: > > On Tue, Nov 24, 2020 at 09:20:19AM +0100, Uwe Kleine-König wrote: [...] > > > state->duty_cycle and state->period are u64, so you're losi

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-27 Thread Uwe Kleine-König
On Fri, Nov 27, 2020 at 12:08:51PM +0100, Thierry Reding wrote: > On Fri, Nov 27, 2020 at 08:11:05AM +0100, Uwe Kleine-König wrote: > > Hello Jonathan, > > > > On Fri, Nov 27, 2020 at 12:19:31AM +0100, Jonathan Neuschäfer wrote: > > > On Tue, Nov 24, 2020 at 09:20:19AM +0100, Uwe Kleine-König wrot

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-27 Thread Thierry Reding
On Fri, Nov 27, 2020 at 08:11:05AM +0100, Uwe Kleine-König wrote: > Hello Jonathan, > > On Fri, Nov 27, 2020 at 12:19:31AM +0100, Jonathan Neuschäfer wrote: > > On Tue, Nov 24, 2020 at 09:20:19AM +0100, Uwe Kleine-König wrote: > > > On Sun, Nov 22, 2020 at 11:27:36PM +0100, Jonathan Neuschäfer wro

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-26 Thread Uwe Kleine-König
Hello Jonathan, On Fri, Nov 27, 2020 at 12:19:31AM +0100, Jonathan Neuschäfer wrote: > On Tue, Nov 24, 2020 at 09:20:19AM +0100, Uwe Kleine-König wrote: > > On Sun, Nov 22, 2020 at 11:27:36PM +0100, Jonathan Neuschäfer wrote: > [...] > > > +/* > > > + * The time base used in the EC is 8MHz, or 125

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-26 Thread Jonathan Neuschäfer
On Tue, Nov 24, 2020 at 09:20:19AM +0100, Uwe Kleine-König wrote: > Hello, > > On Sun, Nov 22, 2020 at 11:27:36PM +0100, Jonathan Neuschäfer wrote: [...] > > +/* > > + * The time base used in the EC is 8MHz, or 125ns. Period and duty cycle > > are > > + * measured in this unit. > > + */ > > +#def

Re: [PATCH v4 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-11-24 Thread Uwe Kleine-König
Hello, On Sun, Nov 22, 2020 at 11:27:36PM +0100, Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM state can't >