Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-10-10 Thread Uwe Kleine-König
On Thu, Oct 10, 2019 at 12:23:21PM -0400, Steven Rostedt wrote: > On Wed, 9 Oct 2019 17:22:18 +0200 > Uwe Kleine-König wrote: > > > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > > > index 3796eb37fb12..6dbec46b7703 100644 > > > --- a/scripts/recordmcount.h > > > +++ b/scripts/r

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-10-10 Thread Steven Rostedt
On Wed, 9 Oct 2019 17:22:18 +0200 Uwe Kleine-König wrote: > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > > index 3796eb37fb12..6dbec46b7703 100644 > > --- a/scripts/recordmcount.h > > +++ b/scripts/recordmcount.h > > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *c

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-10-09 Thread Uwe Kleine-König
On Wed, Oct 09, 2019 at 11:05:38AM -0400, Steven Rostedt wrote: > On Wed, 9 Oct 2019 12:46:26 +0200 > Uwe Kleine-König wrote: > > > > uwe@taurus:~/arietta/kbuild$ ./scripts/recordmcount > > "arch/arm/crypto/aes-cipher-glue.o" > > arch/arm/crypto/aes-cipher-glue.o: failed > > Thanks for the rep

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-10-09 Thread Steven Rostedt
On Wed, 9 Oct 2019 12:46:26 +0200 Uwe Kleine-König wrote: > uwe@taurus:~/arietta/kbuild$ ./scripts/recordmcount > "arch/arm/crypto/aes-cipher-glue.o" > arch/arm/crypto/aes-cipher-glue.o: failed Thanks for the report. > > I didn't debug this further, if you have problems reproducing or need m

Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-10-09 Thread Uwe Kleine-König
Hello, On Wed, Jul 31, 2019 at 11:24:12AM -0700, Matt Helsley wrote: > Recordmcount uses setjmp/longjmp to manage control flow as > it reads and then writes the ELF file. This unusual control > flow is hard to follow and check in addition to being unlike > kernel coding style. > > So we rewrite t