Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2016 14:43:45 +0300 Andrey Ryabinin wrote: > >> This is not about size, this about fragmentation. vmalloc allows to > >> utilize available low-order pages, > >> hence reduce the fragmentation. > > I've attempted to add __vmalloc(STACK_ALLOC_SIZE, alloc_flags, > > PAGE_KERNEL) (a

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-11 Thread Alexander Potapenko
On Fri, Mar 11, 2016 at 12:43 PM, Andrey Ryabinin wrote: > > > On 03/11/2016 02:18 PM, Alexander Potapenko wrote: >> On Thu, Mar 10, 2016 at 5:58 PM, Andrey Ryabinin >> wrote: >>> 2016-03-08 14:42 GMT+03:00 Alexander Potapenko : On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin wrote:

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-11 Thread Andrey Ryabinin
On 03/11/2016 02:18 PM, Alexander Potapenko wrote: > On Thu, Mar 10, 2016 at 5:58 PM, Andrey Ryabinin > wrote: >> 2016-03-08 14:42 GMT+03:00 Alexander Potapenko : >>> On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin >>> wrote: >> >>> + page = alloc_pages(alloc_flag

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-11 Thread Alexander Potapenko
On Thu, Mar 10, 2016 at 5:58 PM, Andrey Ryabinin wrote: > 2016-03-08 14:42 GMT+03:00 Alexander Potapenko : >> On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin >> wrote: > >> + page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); > > STACK_ALLOC_ORDER = 4 - that

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-10 Thread Andrey Ryabinin
2016-03-08 14:42 GMT+03:00 Alexander Potapenko : > On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin > wrote: > + page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); STACK_ALLOC_ORDER = 4 - that's a lot. Do you really need that much? >>> >>> Part of the issue

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-08 Thread Alexander Potapenko
On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin wrote: > > > On 02/29/2016 08:12 PM, Dmitry Vyukov wrote: > diff --git a/lib/Makefile b/lib/Makefile index a7c26a4..10a4ae3 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -167,6 +167,13 @@ obj-$(CONFIG_SG_SPLIT) += sg_split

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-08 Thread Alexander Potapenko
On Mon, Feb 29, 2016 at 5:29 PM, Andrey Ryabinin wrote: > > > On 02/26/2016 07:48 PM, Alexander Potapenko wrote: >> Stack depot will allow KASAN store allocation/deallocation stack traces >> for memory chunks. The stack traces are stored in a hash table and >> referenced by handles which reside in

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-04 Thread Andrey Ryabinin
2016-03-04 18:06 GMT+03:00 Alexander Potapenko : > On Fri, Mar 4, 2016 at 4:01 PM, Andrey Ryabinin > wrote: >> 2016-03-04 17:52 GMT+03:00 Alexander Potapenko : >>> On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin >>> wrote: >>> + >>> + stack->hash = hash; >>> + stack->size =

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-04 Thread Alexander Potapenko
On Fri, Mar 4, 2016 at 4:01 PM, Andrey Ryabinin wrote: > 2016-03-04 17:52 GMT+03:00 Alexander Potapenko : >> On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin >> wrote: >>> >>> >>> On 02/29/2016 08:12 PM, Dmitry Vyukov wrote: >>> >> diff --git a/lib/Makefile b/lib/Makefile >> index a7c26a

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-04 Thread Andrey Ryabinin
2016-03-04 17:52 GMT+03:00 Alexander Potapenko : > On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin > wrote: >> >> >> On 02/29/2016 08:12 PM, Dmitry Vyukov wrote: >> > diff --git a/lib/Makefile b/lib/Makefile > index a7c26a4..10a4ae3 100644 > --- a/lib/Makefile > +++ b/lib/Makefil

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-04 Thread Alexander Potapenko
On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin wrote: > > > On 02/29/2016 08:12 PM, Dmitry Vyukov wrote: > diff --git a/lib/Makefile b/lib/Makefile index a7c26a4..10a4ae3 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -167,6 +167,13 @@ obj-$(CONFIG_SG_SPLIT) += sg_split

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-03-01 Thread Andrey Ryabinin
On 02/29/2016 08:12 PM, Dmitry Vyukov wrote: >>> diff --git a/lib/Makefile b/lib/Makefile >>> index a7c26a4..10a4ae3 100644 >>> --- a/lib/Makefile >>> +++ b/lib/Makefile >>> @@ -167,6 +167,13 @@ obj-$(CONFIG_SG_SPLIT) += sg_split.o >>> obj-$(CONFIG_STMP_DEVICE) += stmp_device.o >>> obj-$(CONFI

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-02-29 Thread Dmitry Vyukov
On Mon, Feb 29, 2016 at 5:29 PM, Andrey Ryabinin wrote: > > > On 02/26/2016 07:48 PM, Alexander Potapenko wrote: >> Stack depot will allow KASAN store allocation/deallocation stack traces >> for memory chunks. The stack traces are stored in a hash table and >> referenced by handles which reside in

Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB

2016-02-29 Thread Andrey Ryabinin
On 02/26/2016 07:48 PM, Alexander Potapenko wrote: > Stack depot will allow KASAN store allocation/deallocation stack traces > for memory chunks. The stack traces are stored in a hash table and > referenced by handles which reside in the kasan_alloc_meta and > kasan_free_meta structures in the al