Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
On Sun, 2016-01-03 at 22:05 +, One Thousand Gnomes wrote: > On Sun, 03 Jan 2016 13:46:22 -0800 > Joe Perches wrote: > > > (using an email address for James that shouldn't bounce) > > > > On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > > > I would beg to differ. As a tool

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
(using an email address for James that shouldn't bounce) On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > I would beg to differ. As a tool for understanding the > > > differences as you > > > step through the versions it's invaluable. > > > > This removes intentional formatting

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread One Thousand Gnomes
> > I would beg to differ. As a tool for understanding the differences as you > > step through the versions it's invaluable. > > This removes intentional formatting that > makes reading comments easier. And this matters at the end of the patch series because ? -- To unsubscribe from this list: s

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
On Sun, 2016-01-03 at 14:10 +, One Thousand Gnomes wrote: > On Sat, 02 Jan 2016 23:54:28 -0800 > Joe Perches wrote: > > > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > > Hanging indentation was a poor choice for the text inside comments. It > > > has been used in the wrong places a

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread One Thousand Gnomes
On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file.

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Finn Thain
On Sat, 2 Jan 2016, Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file. One fork of the

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-02 Thread Joe Perches
On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > Hanging indentation was a poor choice for the text inside comments. It > has been used in the wrong places and done badly elsewhere. There is > little consistency within any file. One fork of the core driver uses > tabs for this indentation whi