Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Shubham Bansal
Hi David, On Tue, Aug 22, 2017 at 10:02 PM, David Miller wrote: > > You posted this 4 times. :-( > > I hope I applied the right one. All 4 of these are the same patch. I mistakenly sent it 4 times. My apologies for that. > > Go check net-next and please send me any necessary fix up patches. I ju

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread David Miller
You posted this 4 times. :-( I hope I applied the right one. Go check net-next and please send me any necessary fix up patches. Thanks.

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 05:08 PM, Daniel Borkmann wrote: On 08/22/2017 08:36 AM, Shubham Bansal wrote: [...] + +static int out_offset = -1; /* initialized on the first pass of build_body() */ Hm, why is this a global var actually? There can be multiple parallel calls to bpf_int_jit_compile(), we don't t

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 08:36 AM, Shubham Bansal wrote: [...] + +static int out_offset = -1; /* initialized on the first pass of build_body() */ Hm, why is this a global var actually? There can be multiple parallel calls to bpf_int_jit_compile(), we don't take a global lock on this. Unless I'm missing so

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Shubham Bansal
Please ignore this mail. Sent it by mistake. Sent the correct patch later on.

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Shubham Bansal
Russell, David, Alexei, Daniel and Kees. Please check this patch and lets finish it. Thanks.