Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

2018-01-02 Thread David Howells
NeilBrown wrote: > David: do you agree that this sort of content would be appropriate in > that file (which you apparently authored). Would you like to update it, > or shall I? Please update it. Thanks, David

Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

2017-12-11 Thread NeilBrown
On Mon, Dec 11 2017, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel for > the same entry cached in auth.unix.gid, racing in the call of groups_sort, > corrupting the groups for that entry and leading to permission denials for > the client. > >

Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

2017-12-11 Thread J. Bruce Fields
ACK. (Assuming somebody else takes it--Andrew? Al? Or I can take it through the nfsd tree. I'm not sure who owns the stuff under kernel/.) --b. On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel for >

Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

2017-12-11 Thread Matthew Wilcox
On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel for > the same entry cached in auth.unix.gid, racing in the call of groups_sort, > corrupting the groups for that entry and leading to permission denials fo