Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-03-01 Thread Huang Rui
On Tue, Mar 01, 2016 at 02:58:39PM +0100, Borislav Petkov wrote: > On Mon, Feb 29, 2016 at 12:30:47PM +0100, Thomas Gleixner wrote: > > On Tue, 1 Mar 2016, Huang Rui wrote: > > > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > > > > > +static int __init amd_power_pmu_init(void) >

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-03-01 Thread Borislav Petkov
On Mon, Feb 29, 2016 at 12:30:47PM +0100, Thomas Gleixner wrote: > On Tue, 1 Mar 2016, Huang Rui wrote: > > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > > > > +static int __init amd_power_pmu_init(void) > > > > +{ > > > > + int i, ret; > > > > + u64 tmp; > > > > +

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-02-29 Thread Thomas Gleixner
On Tue, 1 Mar 2016, Huang Rui wrote: > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > > > +static int __init amd_power_pmu_init(void) > > > +{ > > > + int i, ret; > > > + u64 tmp; > > > + > > > + if (!x86_match_cpu(cpu_match)) > > > + return 0; > > > + > > > + if (!boot_

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-02-29 Thread Huang Rui
Hi Thomas, Thank you to your comments. :-) On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > On Fri, 26 Feb 2016, Huang Rui wrote: > > > + > > +static DEFINE_PER_CPU(struct power_pmu_masks *, amd_power_pmu); > > This is complete overkill, really. > > > +static int power_cpu_ex

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-02-28 Thread Huang Rui
On Fri, Feb 26, 2016 at 11:29:52AM +0100, Borislav Petkov wrote: > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > > On Fri, 26 Feb 2016, Huang Rui wrote: > > > +/* Event code: LSB 8 bits, passed in attr->config any other bit is > > > reserved. */ > > > +#define AMD_POWER_EVENT_

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-02-26 Thread Borislav Petkov
On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > On Fri, 26 Feb 2016, Huang Rui wrote: > > +/* Event code: LSB 8 bits, passed in attr->config any other bit is > > reserved. */ > > +#define AMD_POWER_EVENT_MASK 0xFFULL > > + > > +#define MAX_CUS8 > > What's that define

Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-02-26 Thread Thomas Gleixner
On Fri, 26 Feb 2016, Huang Rui wrote: > +/* Event code: LSB 8 bits, passed in attr->config any other bit is reserved. > */ > +#define AMD_POWER_EVENT_MASK 0xFFULL > + > +#define MAX_CUS 8 What's that define for? Max compute units? So is that stuff eternaly limited to 8? > +struct power_pmu_