Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Nick Desaulniers
On Thu, Jan 21, 2021 at 5:49 PM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 2:43 AM Nick Desaulniers > wrote: > > > > On Wed, Jan 20, 2021 at 6:03 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dil

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 2:43 AM Nick Desaulniers wrote: > > On Wed, Jan 20, 2021 at 6:03 PM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Nick Desaulniers
On Wed, Jan 20, 2021 at 6:03 PM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling w

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 3:03 AM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling w

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Bill Wendling
On Wed, Jan 20, 2021 at 4:51 PM Nick Desaulniers wrote: > > Thanks Bill, mostly questions below. Patch looks good to me modulo > disabling profiling for one crypto TU, mixing style of pre/post > increment, and some comments around locking. With those addressed, > I'm hoping akpm@ would consider

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Nick Desaulniers
Thanks Bill, mostly questions below. Patch looks good to me modulo disabling profiling for one crypto TU, mixing style of pre/post increment, and some comments around locking. With those addressed, I'm hoping akpm@ would consider picking this up. On Sat, Jan 16, 2021 at 1:44 AM Bill Wendling wr

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-19 Thread Nick Desaulniers
On Sat, Jan 16, 2021 at 1:44 AM Bill Wendling wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is collected from > /sys/k

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Bill Wendling
On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > > > > > [ big snip ] > > > > > > [More snippage.] > > > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > > > [ big snip ] > > > > [More snippage.] > > > > > [ CC Fangrui ] > > > > > > With the attached... > > > > > >[PATCH

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > [ big snip ] > > [More snippage.] > > > [ CC Fangrui ] > > > > With the attached... > > > >[PATCH v3] module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for > > undefined symbols

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Bill Wendling
On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > [ big snip ] [More snippage.] > [ CC Fangrui ] > > With the attached... > >[PATCH v3] module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for > undefined symbols > > ...I was finally able to boot into a rebuild PGO-optimized Linux-kernel.

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Bill Wendling
On Sun, Jan 17, 2021 at 9:42 AM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 1:05 PM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 12:58 PM Sedat Dilek wrote: > > > > > > On Sun, Jan 17, 2021 at 12:42 PM Sedat Dilek > > > wrote: > > > > > > > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dil

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 1:05 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 12:58 PM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 12:42 PM Sedat Dilek wrote: > > > > > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek > > > wrote: > > > > > > > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Di

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 12:42 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > > > > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek > > > wrote: > > > > > > > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wen

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > > > > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > > > > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Cl

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > > > wrote: > > > > > > > > From: Sami Tolvanen

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > > wrote: > > > > > > From: Sami Tolvanen > > > > > > Enable the use of clang's Profile-Guided Optimization[1].

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Bill Wendling
On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile, the kernel is instrumented with PGO counte

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 6:38 PM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile, the kernel is instrumented with PGO coun

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data i