Re: [PATCH v5] x86/fsgsbase/64: Fix the base write helper functions

2018-11-22 Thread Andy Lutomirski
On Thu, Nov 22, 2018 at 4:42 PM Andy Lutomirski wrote: > > On Thu, Nov 22, 2018 at 12:56 PM Ingo Molnar wrote: > > > > > > * Andy Lutomirski wrote: > > > > > On Fri, Nov 16, 2018 at 3:27 PM Chang S. Bae > > > wrote: > > > > > > > > The helper functions that purport to write the base should jus

Re: [PATCH v5] x86/fsgsbase/64: Fix the base write helper functions

2018-11-22 Thread Andy Lutomirski
On Thu, Nov 22, 2018 at 12:56 PM Ingo Molnar wrote: > > > * Andy Lutomirski wrote: > > > On Fri, Nov 16, 2018 at 3:27 PM Chang S. Bae > > wrote: > > > > > > The helper functions that purport to write the base should just write it > > > only. It shouldn't have magic optimizations to change the i

Re: [PATCH v5] x86/fsgsbase/64: Fix the base write helper functions

2018-11-22 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Fri, Nov 16, 2018 at 3:27 PM Chang S. Bae wrote: > > > > The helper functions that purport to write the base should just write it > > only. It shouldn't have magic optimizations to change the index. > > > > Make the index explicitly changed from the caller, instea

Re: [PATCH v5] x86/fsgsbase/64: Fix the base write helper functions

2018-11-18 Thread Andy Lutomirski
On Fri, Nov 16, 2018 at 3:27 PM Chang S. Bae wrote: > > The helper functions that purport to write the base should just write it > only. It shouldn't have magic optimizations to change the index. > > Make the index explicitly changed from the caller, instead of including > the code in the helpers.