Re: [PATCH v5 01/21] tpm2: add new tpm2 commands according to TCG 1.36

2018-10-01 Thread Jarkko Sakkinen
On Sat, Sep 29, 2018 at 01:30:15AM +0300, Tomas Winkler wrote: > 1. TPM2_CC_LAST has moved from 182 to 193 > 2. Convert tpm2_ordinal_duration from an array into a switch statement, >as there are not so many commands that require special duration >relative to a number of commands, the switch

Re: [PATCH v5 01/21] tpm2: add new tpm2 commands according to TCG 1.36

2018-10-01 Thread Jarkko Sakkinen
Looks good. Just some minor bits. On Sat, Sep 29, 2018 at 01:30:15AM +0300, Tomas Winkler wrote: > 1. TPM2_CC_LAST has moved from 182 to 193 > 2. Convert tpm2_ordinal_duration from an array into a switch statement, >as there are not so many commands that require special duration >relative