Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-18 Thread Tejun Heo
Hey, Glauber. On Thu, Oct 18, 2012 at 09:01:23PM +0400, Glauber Costa wrote: > That is the offensive part. But it is also how things are done in memcg > right now, and there is nothing fundamentally different in this one. > Whatever lands in the remaining offenders, can land in here. I think the

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-18 Thread Tejun Heo
Hello, David. On Wed, Oct 17, 2012 at 03:08:04PM -0700, David Rientjes wrote: > > +static int memcg_update_kmem_limit(struct cgroup *cont, u64 val) > > +{ > > + int ret = -EINVAL; > > +#ifdef CONFIG_MEMCG_KMEM > > + struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); > > + /* > > +* F

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-18 Thread Glauber Costa
On 10/18/2012 02:12 AM, Andrew Morton wrote: > On Tue, 16 Oct 2012 14:16:41 +0400 > Glauber Costa wrote: > >> This patch adds the basic infrastructure for the accounting of kernel >> memory. To control that, the following files are created: >> >> * memory.kmem.usage_in_bytes >> * memory.kmem.li

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-18 Thread Glauber Costa
On 10/18/2012 02:08 AM, David Rientjes wrote: > On Tue, 16 Oct 2012, Glauber Costa wrote: > >> This patch adds the basic infrastructure for the accounting of kernel >> memory. To control that, the following files are created: >> >> * memory.kmem.usage_in_bytes >> * memory.kmem.limit_in_bytes >>

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-17 Thread Andrew Morton
On Tue, 16 Oct 2012 14:16:41 +0400 Glauber Costa wrote: > This patch adds the basic infrastructure for the accounting of kernel > memory. To control that, the following files are created: > > * memory.kmem.usage_in_bytes > * memory.kmem.limit_in_bytes > * memory.kmem.failcnt gargh. "failcnt

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-17 Thread David Rientjes
On Tue, 16 Oct 2012, Glauber Costa wrote: > This patch adds the basic infrastructure for the accounting of kernel > memory. To control that, the following files are created: > > * memory.kmem.usage_in_bytes > * memory.kmem.limit_in_bytes > * memory.kmem.failcnt > * memory.kmem.max_usage_in_by

Re: [PATCH v5 04/14] kmem accounting basic infrastructure

2012-10-16 Thread Michal Hocko
On Tue 16-10-12 14:16:41, Glauber Costa wrote: > This patch adds the basic infrastructure for the accounting of kernel > memory. To control that, the following files are created: > > * memory.kmem.usage_in_bytes > * memory.kmem.limit_in_bytes > * memory.kmem.failcnt > * memory.kmem.max_usage_i