Re: [PATCH v5 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data

2018-04-01 Thread Sricharan R
On 3/27/2018 10:50 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +#include "qcom-ipq4019.dtsi" >> +#include >> +#include >> + >> +/ { >> +model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK07.1"; >> +compatible = "qcom,ipq4019"; > > The board should se

Re: [PATCH v5 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data

2018-03-27 Thread Bjorn Andersson
On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > +#include "qcom-ipq4019.dtsi" > +#include > +#include > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK07.1"; > + compatible = "qcom,ipq4019"; The board should set these, so you shouldn't need to specify them here. And yo