Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-21 Thread Pratyush Yadav
On 21/05/20 04:09PM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > > > > > + /* Get 8D-8D-8D fast read opcode and dummy cycles. */ > > > > > > + opcode = FIELD_GET(PROFILE1_DWORD1_RD_FAST_CMD, table[0]); > > > > > > + > > > > > > + /* > > > > > > +* Update the fast read setting

Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-21 Thread masonccyang
Hi Pratyush, > > > > > > > +/** > > > > > + * spi_nor_parse_profile1() - parse the xSPI Profile 1.0 table > > > > > + * @nor: pointer to a 'struct spi_nor' > > > > > + * @param_header: pointer to the 'struct sfdp_parameter_header' > > > > describing > > > > > + * the 4-Byte Ad

Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-20 Thread Pratyush Yadav
On 20/05/20 05:40PM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > > > +/** > > > > + * spi_nor_parse_profile1() - parse the xSPI Profile 1.0 table > > > > + * @nor: pointer to a 'struct spi_nor' > > > > + * @param_header: pointer to the 'struct sfdp_parameter_header' > > > desc

Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-20 Thread masonccyang
Hi Pratyush, > > > +/** > > > + * spi_nor_parse_profile1() - parse the xSPI Profile 1.0 table > > > + * @nor: pointer to a 'struct spi_nor' > > > + * @param_header: pointer to the 'struct sfdp_parameter_header' > > describing > > > + * the 4-Byte Address Instruction Table lengt

Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-20 Thread Pratyush Yadav
Hi Mason, On 20/05/20 03:59PM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > +/** > > + * spi_nor_parse_profile1() - parse the xSPI Profile 1.0 table > > + * @nor: pointer to a 'struct spi_nor' > > + * @param_header: pointer to the 'struct sfdp_parameter_header' > describing > >

Re: [PATCH v5 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table

2020-05-20 Thread masonccyang
Hi Pratyush, > +/** > + * spi_nor_parse_profile1() - parse the xSPI Profile 1.0 table > + * @nor: pointer to a 'struct spi_nor' > + * @param_header: pointer to the 'struct sfdp_parameter_header' describing > + * the 4-Byte Address Instruction Table length and version. > + * @par