Alexey Budankov writes:
>>> +static void
>>> +perf_event_groups_insert(struct perf_event_groups *groups,
>>> + struct perf_event *event)
>>> +{
>>> + struct rb_node **node;
>>> + struct rb_node *parent;
>>> + struct perf_event *node_event;
>>> +
>>> + WARN_ON_ONCE(!groups || !ev
Hi,
On 18.07.2017 15:29, Alexander Shishkin wrote:
> Alexey Budankov writes:
>
>> +/*
>> + * Helper function to test if event groups are empty;
>> + */
>> +static int
>> +perf_event_groups_empty(struct perf_event_groups *groups)
>> +{
>> +return list_empty(&groups->list);
>> +}
>
> This doe
Hi,
On 18.07.2017 15:02, Alexander Shishkin wrote:
> Alexey Budankov writes:
>
>> +static void
>> +perf_event_groups_rotate(struct perf_event_groups *groups, int cpu)
>> +{
>> +struct rb_node *node;
>> +struct perf_event *node_event;
>> +
>> +WARN_ON_ONCE(!groups);
>
> This seems re
Alexey Budankov writes:
> +/*
> + * Helper function to test if event groups are empty;
> + */
> +static int
> +perf_event_groups_empty(struct perf_event_groups *groups)
> +{
> + return list_empty(&groups->list);
> +}
This doesn't seem useful, it's only used once. Also, it's not clear how
acc
Alexey Budankov writes:
> +static void
> +perf_event_groups_rotate(struct perf_event_groups *groups, int cpu)
> +{
> + struct rb_node *node;
> + struct perf_event *node_event;
> +
> + WARN_ON_ONCE(!groups);
This seems redundant.
> +
> + list_rotate_left(&groups->list);
> +
> +
5 matches
Mail list logo
