Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-11-04 Thread Maxime Coquelin
Hi Wolfram, On 11/01/2013 12:16 PM, Wolfram Sang wrote: Hi, ... diff --git a/Documentation/devicetree/bindings/i2c/i2c-st.txt b/Documentation/devicetree/bindings/i2c/i2c-st.txt new file mode 100644 index 000..8b2fd0b --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-st.txt @@

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-11-01 Thread srinivas kandagatla
On 28/10/13 15:02, Maxime Coquelin wrote: >> >> 6> IMHO, the compatible string should be "vendor,-" >> rather than first SoC. > I agree. > In this case, we add support to revision 4 of SSC IP. Its not the revision its name of the new IP which is SSC4. However this driver is also compatible with ol

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-11-01 Thread Wolfram Sang
Hi, On Mon, Oct 14, 2013 at 02:46:49PM +0200, Maxime COQUELIN wrote: > This patch adds support to SSC (Synchronous Serial Controller) > I2C driver. This IP also supports SPI protocol, but this is not > the aim of this driver. > > This IP is embedded in all ST SoCs for Set-top box platorms, and >

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-29 Thread Kumar Gala
On Oct 29, 2013, at 8:19 AM, Maxime Coquelin wrote: > > On 10/28/2013 08:25 PM, Kumar Gala wrote: >> On Oct 14, 2013, at 7:46 AM, Maxime COQUELIN wrote: >> >>> This patch adds support to SSC (Synchronous Serial Controller) >>> I2C driver. This IP also supports SPI protocol, but this is not >>>

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-29 Thread Maxime Coquelin
On 10/28/2013 08:25 PM, Kumar Gala wrote: On Oct 14, 2013, at 7:46 AM, Maxime COQUELIN wrote: This patch adds support to SSC (Synchronous Serial Controller) I2C driver. This IP also supports SPI protocol, but this is not the aim of this driver. This IP is embedded in all ST SoCs for Set-top b

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-28 Thread Kumar Gala
On Oct 14, 2013, at 7:46 AM, Maxime COQUELIN wrote: > This patch adds support to SSC (Synchronous Serial Controller) > I2C driver. This IP also supports SPI protocol, but this is not > the aim of this driver. > > This IP is embedded in all ST SoCs for Set-top box platorms, and > supports I2C Sta

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-28 Thread Maxime Coquelin
On 10/18/2013 10:22 AM, Srinivas KANDAGATLA wrote: On 17/10/13 15:49, Lucas Stach wrote: Am Donnerstag, den 17.10.2013, 15:30 +0100 schrieb srinivas kandagatla: [...] Sorry to ask this but, Where is this requirement coming from? I have not spotted any thing as such in ePAPR specs. All the sp

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-18 Thread srinivas kandagatla
On 17/10/13 15:49, Lucas Stach wrote: > Am Donnerstag, den 17.10.2013, 15:30 +0100 schrieb srinivas kandagatla: > [...] >> Sorry to ask this but, Where is this requirement coming from? >> I have not spotted any thing as such in ePAPR specs. >> >> >> All the spec says is. >> === >> The compatible pr

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:53 Thu 17 Oct , Lee Jones wrote: > On Thu, 17 Oct 2013, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > > > On 17/10/13 08:27, Maxime COQUELIN wrote: > > > > ... > > > >>> >> + > > > >>> >> +static struct of_device_id st_i2c_match[] =

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > On 17/10/13 08:27, Maxime COQUELIN wrote: > > ... > >>> >> + > >>> >> +static struct of_device_id st_i2c_match[] = { > >>> >> + { .compatible = "st,comms-ssc-i2c", }, > >> > the rules is to put the first soc that use the ip in the compatibl

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Maxime COQUELIN
On 10/17/2013 04:16 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 09:27 Thu 17 Oct , Maxime COQUELIN wrote: >> Hi Jean-Christophe, >> >> On 10/16/2013 05:14 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> >> >> ... + +static inline void st_i2c_set_bits(void __iomem *reg, u32 mask)

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Lee Jones
On Thu, 17 Oct 2013, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > > On 17/10/13 08:27, Maxime COQUELIN wrote: > > > ... > > >>> >> + > > >>> >> +static struct of_device_id st_i2c_match[] = { > > >>> >> + { .compatible = "st,comms-ssc-i2c", },

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:27 Thu 17 Oct , Maxime COQUELIN wrote: > Hi Jean-Christophe, > > On 10/16/2013 05:14 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > ... > >> + > >> +static inline void st_i2c_set_bits(void __iomem *reg, u32 mask) > >> +{ > >> + writel(readl(reg) | mask, reg); > >> +} > >> + > >>

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Lucas Stach
Am Donnerstag, den 17.10.2013, 15:30 +0100 schrieb srinivas kandagatla: [...] > Sorry to ask this but, Where is this requirement coming from? > I have not spotted any thing as such in ePAPR specs. > > > All the spec says is. > === > The compatible property value consists of one or more strings th

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread srinivas kandagatla
On 17/10/13 15:19, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:33 Thu 17 Oct , srinivas kandagatla wrote: >> On 17/10/13 08:27, Maxime COQUELIN wrote: >>> ... >>> + >>> +static struct of_device_id st_i2c_match[] = { >>> + { .compatible = "st,comms-ssc-i2c", }, > the rule

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread srinivas kandagatla
On 17/10/13 08:27, Maxime COQUELIN wrote: > ... >>> >> + >>> >> +static struct of_device_id st_i2c_match[] = { >>> >> + { .compatible = "st,comms-ssc-i2c", }, >> > the rules is to put the first soc that use the ip in the compatible >> > as st,sti7100-scc-i2c > Ok. There are no plans to upstream

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Maxime COQUELIN
Hi Jean-Christophe, On 10/16/2013 05:14 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: ... >> + >> +static inline void st_i2c_set_bits(void __iomem *reg, u32 mask) >> +{ >> + writel(readl(reg) | mask, reg); >> +} >> + >> +static inline void st_i2c_clr_bits(void __iomem *reg, u32 mask) >> +{ >>

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-16 Thread Jean-Christophe PLAGNIOL-VILLARD
> +/** > + * struct st_i2c_dev - private data of the controller > + * @adap: I2C adapter for this controller > + * @dev: device for this controller > + * @base: virtual memory area > + * @complete: completion of I2C message > + * @irq: interrupt line for th controller > + * @clk: hw ssc block clock