Re: [PATCH v5 11/13] ARM: dts: ipq8074: Add peripheral nodes

2018-04-01 Thread Sricharan R
On 3/27/2018 11:15 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +serial_blsp0: serial@78af000 { > > Please try to have a single scheme for how you name your labels; this is > serial0 or blsp1_uart1. > > [..] >> +i2c_0: i2c@78b6000 { >

Re: [PATCH v5 11/13] ARM: dts: ipq8074: Add peripheral nodes

2018-03-27 Thread Bjorn Andersson
On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > + serial_blsp0: serial@78af000 { Please try to have a single scheme for how you name your labels; this is serial0 or blsp1_uart1. [..] > + i2c_0: i2c@78b6000 { As in the previous patches, this is the 2nd i2c master in the