Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Tony Krowiak
On 06/11/2018 12:50 PM, Halil Pasic wrote: On 06/11/2018 06:26 PM, Tony Krowiak wrote: @Janosch: Does core KVM share my opinion? At least I do. KVM does not care about who has which crypto queue/card. I'd like to have a driver that does internal bookkeeping and then registers the crycb with

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Halil Pasic
On 06/11/2018 06:26 PM, Tony Krowiak wrote: @Janosch: Does core KVM share my opinion? At least I do. KVM does not care about who has which crypto queue/card. I'd like to have a driver that does internal bookkeeping and then registers the crycb with KVM, so the VM can use it. I am not sure 

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Tony Krowiak
On 06/11/2018 07:49 AM, Janosch Frank wrote: On 11.06.2018 13:32, Halil Pasic wrote: On 06/11/2018 11:23 AM, Pierre Morel wrote: On 08/06/2018 23:59, Tony Krowiak wrote: On 06/07/2018 01:15 PM, Pierre Morel wrote: ...snip... Why maintain a list of kvm_ap_matrix structures if we don't have

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Tony Krowiak
On 06/11/2018 05:23 AM, Pierre Morel wrote: On 08/06/2018 23:59, Tony Krowiak wrote: On 06/07/2018 01:15 PM, Pierre Morel wrote: ...snip... Why maintain a list of kvm_ap_matrix structures if we don't have to; it is stored with the mediated matrix device which is passed in to all of the

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Tony Krowiak
On 06/11/2018 07:32 AM, Halil Pasic wrote: On 06/11/2018 11:23 AM, Pierre Morel wrote: On 08/06/2018 23:59, Tony Krowiak wrote: On 06/07/2018 01:15 PM, Pierre Morel wrote: ...snip... Why maintain a list of kvm_ap_matrix structures if we don't have to; it is stored with the mediated

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Janosch Frank
On 11.06.2018 13:32, Halil Pasic wrote: > > > On 06/11/2018 11:23 AM, Pierre Morel wrote: >> On 08/06/2018 23:59, Tony Krowiak wrote: >>> On 06/07/2018 01:15 PM, Pierre Morel wrote: >> >> ...snip... >> >> >>> >>> Why maintain a list of kvm_ap_matrix structures if we don't have to

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Halil Pasic
On 06/11/2018 11:23 AM, Pierre Morel wrote: On 08/06/2018 23:59, Tony Krowiak wrote: On 06/07/2018 01:15 PM, Pierre Morel wrote: ...snip... Why maintain a list of kvm_ap_matrix structures if we don't have to; it is stored with the mediated matrix device which is passed in to all of

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-11 Thread Pierre Morel
On 08/06/2018 23:59, Tony Krowiak wrote: On 06/07/2018 01:15 PM, Pierre Morel wrote: ...snip... Why maintain a list of kvm_ap_matrix structures if we don't have to; it is stored with the mediated matrix device which is passed in to all of the vfio_ap driver callbacks. Because using

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-08 Thread Tony Krowiak
On 06/07/2018 01:15 PM, Pierre Morel wrote: We have internal structures like the ap_matrix and kvm_ap_matrix which look like the bus/devices we had previously but are differently or not at all integrated with the LDD. What is LDD? Are you talking about dependencies between the vfio_ap devi

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-07 Thread Pierre Morel
On 07/06/2018 18:30, Tony Krowiak wrote: On 06/07/2018 11:20 AM, Pierre Morel wrote: On 07/06/2018 15:54, Tony Krowiak wrote: On 06/06/2018 01:40 PM, Pierre Morel wrote: On 06/06/2018 18:08, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-07 Thread Tony Krowiak
On 06/07/2018 11:20 AM, Pierre Morel wrote: On 07/06/2018 15:54, Tony Krowiak wrote: On 06/06/2018 01:40 PM, Pierre Morel wrote: On 06/06/2018 18:08, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-07 Thread Pierre Morel
On 07/06/2018 15:54, Tony Krowiak wrote: On 06/06/2018 01:40 PM, Pierre Morel wrote: On 06/06/2018 18:08, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-07 Thread Tony Krowiak
On 06/06/2018 01:40 PM, Pierre Morel wrote: On 06/06/2018 18:08, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-07 Thread Tony Krowiak
On 06/06/2018 12:08 PM, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-06 Thread Pierre Morel
On 06/06/2018 18:08, Pierre Morel wrote: On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-06 Thread Pierre Morel
On 06/06/2018 16:28, Tony Krowiak wrote: On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wro

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-06 Thread Tony Krowiak
On 06/05/2018 08:19 AM, Pierre Morel wrote: On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the m

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-06-05 Thread Pierre Morel
On 30/05/2018 16:33, Tony Krowiak wrote: On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-05-30 Thread Tony Krowiak
On 05/24/2018 05:08 AM, Pierre Morel wrote: On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-05-24 Thread Pierre Morel
On 23/05/2018 16:45, Tony Krowiak wrote: On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-05-23 Thread Tony Krowiak
On 05/16/2018 04:03 AM, Pierre Morel wrote: On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will g

Re: [PATCH v5 11/13] KVM: s390: implement mediated device open callback

2018-05-16 Thread Pierre Morel
On 07/05/2018 17:11, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the guest's kvm structure. With